Majid-Eismann / robocop

Other
1 stars 0 forks source link

Refactor ph label cleanup functions #1

Open markheckmann opened 2 months ago

markheckmann commented 2 months ago

We might consider slightly refactoring https://github.com/Majid-Eismann/robocop/blob/main/R/layout.R

markheckmann commented 2 months ago

A function to clean placeholder labels should probably be part of the officer package, as you already suggested in this issue. As long as its not integrated in officer, it should probably be a separate exported function here, with a naming matching the officer convention. Maybe layout_check_ph or layout_dedupe_ph or similar would be suitable? The function can then either rename, delete or just inform the user about duplicated ph labels, for example like this:

layout_dedupe_ph(x, action = c("check", "rename", "delete"))