Closed edwardchalstrey1 closed 3 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Ok with regard to the GitGuardian check, there's not any secrets in the code per se, but looks like it has an issue with the way I'm referencing my stored secret I use to build the docker container used to run my tests (which is safely secured on my GitHub account). I can look into this at a later date, but for now:
local.py
settingsOk with regard to the GitGuardian check
- I will remove the CI from this branch for now, this is used to run my tests, but we can merge this separately later if you want to have tests running on your repo too
- I will remove the highlighted part from the
local.py
settings
This is still a problem because it's in the Git history, however I don't think the things identified actually pose any security risk. Let me know if you disagree, but hopefully I can avoid re-writing the Git history.
Closing this as per discussion on https://github.com/edwardchalstrey1/seshat/issues/176 - we will instead set up a new GitHub organisation and repo
Hi @MajidBenam - this PR includes:
Qing
branch that aren't on thisdev
branch already (I merged this into my fork today, so it's up to date with 2c7504aAs we have discussed, you can set up a dev server to test this before we roll this out to the live site. You'll need to consider the following to test these changes:
docs/setup.md
, which is similar to your own Notion documentation, but also includes installing the PostGIS extension and geospatial packages. You will also need to follow the instructions to populate the Cliopatria and GADM shape data tables fromdocs/spatialdb.md
(ignore the top part of this doc about creating new datasets). I have added the latest Cliopatria shape dataset to a google drive here.settings
(and tomanage.py
) can be changed to suit a configuration that matches your production server. I've tried to editlocal.py
andbase.py
so that it works for me without interfering with your production settings, but you can check that and modify if needed. A key change is theENGINE
is changed to'django.contrib.gis.db.backends.postgis'
.If you want to look at a PR with a clearer diff with these changes that doesn't include your work on the Qing branch, there's one here on my fork which you may find easier to look through: https://github.com/edwardchalstrey1/seshat/pull/134/files
I think that should be all, let me know if you need some help with this. After we merge this and you are satisfied it works on a development environment (with any modifications you make to settings etc), I expect you can merge
dev
intoQing
and perform the same steps on the live site.