search

Majiir / Kethane

Resource mining and processing plugin for Kerbal Space Program.
http://forum.kerbalspaceprogram.com/showthread.php/23979-Kethane
Other
117 stars 32 forks source link

Add basic science experiment "Kethane Scan" #233

Closed DavidSouther closed 1 year ago

DavidSouther commented 10 years ago

This is a really bad way to add science to Kethan - the Small Scanner Unit behaves like a science experiment that can gather 50 science at a time, up to 500 science. (This is not how Squad's science is balanced.) A better solution would be adding science per kethan square scanned.

See the conversation in #228

erendrake commented 10 years ago

you are really selling your own pull request there :) I always merge in pulls that start with "This is a really bad...."

DavidSouther commented 10 years ago

Hah, this PR as is isn't really meant for merge, just a continuation of the conversation in #228 :)

Majiir commented 10 years ago

Ah... yes, I agree it's a really bad way to add science generation. One suggestion: it looks like your editor or git client has changed whitespace or newlines, so the diffs are a mess. If you clean that up, this might serve as a better reference.

erendrake commented 10 years ago

I have found that when you are on a multiplatform project everyone should have the following setting on in their git config

git config --global core.autocrlf true
DavidSouther commented 10 years ago

Yeah, I usually have that on. Not sure if git/vim/sublime/ksp(j/k)? did that. Fixed now :)