search

Majiir / Kethane

Resource mining and processing plugin for Kerbal Space Program.
http://forum.kerbalspaceprogram.com/showthread.php/23979-Kethane
Other
117 stars 32 forks source link

KSP 0.9 support? #281

Open Arduinology opened 9 years ago

Arduinology commented 9 years ago

Any plans for support in KSP 0.9 beta?

Rene-Sackers commented 9 years ago

This guy seems to have sorta fixed it... But didn't bother to make a commit. I'll poke him. http://forum.kerbalspaceprogram.com/threads/23979-Kethane-Pack-0-9-2-New-cinematic-trailer%21-0-25-compatibility-update?p=1608640&viewfull=1#post1608640

tomaszmrugalski commented 9 years ago

Hi, I'm thomson from KSP forum. Unfortunately, I'm visiting my family for christmas, and don't have access to my desktop. Will get back home on Saturday. If this is not solved by then, ping me again and I'll send pull request. Anyway, my changes were minimal:

  1. Updated Application.unityVersion to "4.5.5f1" in Plugin/Kethane/Utilities/CompatibilityChecker.cs
  2. In Plugin/Kethane/UserInterface/MapOverlay.cs in line 55 replaced: scene != GameScenes.FLIGHT && scene != GameScenes.TRACKSTATION with scene != GameScenes.TRACKSTATION

Change 2 fixed the problem of having broken button during flight. It was overlapping other buttons. One guy complained that this caused map view button to disappear, so it's more of a hack rather than a proper fix. Unfortunately, I don't know anything about KSP API, so I can't fix is properly.

baranowb commented 9 years ago

Tomasz: ping

Olympic1 commented 9 years ago

pinged him, waiting on a response

tomaszmrugalski commented 9 years ago

Guys, I don't have anything to contribute. Identical changes to what I did are on majiir's master already. Someone else sent identical version bump. See commit f4c077ad33ba6be0a23a3502d5df336bbd908b91 from 4 days ago.

The only "fix" I did was for the kethane icon overlapping in some views. I tried to test it, but now I can't reproduce the original issue. So don't fix it if it ain't broken :)

DianaNites commented 9 years ago

that explains why the tracking station fix is needed.