search

Majiir / RealtimeRender

Map rendering plugin for Bukkit that updates as the world changes.
2 stars 1 forks source link

Updated to the new Event Handling #31

Closed Vorthos closed 12 years ago

Vorthos commented 12 years ago

The WorldListener class extended in RealtimeRenderWorldListener no longer exists. Updated to new method for listeners.

Also updated the event registration method to the new method.

As far as I can tell, these are the only bukkit update induced changes needed.

Majiir commented 12 years ago

Looks good, but it won't merge cleanly into the development branch. For now, use Maven to build the plugin (mvn install) on your end and I'll get to this Monday or Tuesday.

Majiir commented 12 years ago

Are any changes necessary in the chunk handling code, since they changed the height limit and all? (My code assumes a 128-high map.)

Vorthos commented 12 years ago

Looking into that, there are some instances of "127" and "128" that should probably be changed... and some related "32768" instances (16x16x128)

From my before dinner glances, the assumption is being used to limit memory use and safely loop. Leaving them as is won't kill the plugin, but will ignore everything over y=127.

Majiir commented 12 years ago

Changes have been implemented (separately). Closing pull request.