search

MajkiIT / polish-ads-filter

CertyficateIT - Oficjalne polskie filtry do Adblock, uBlock Origin, Adguard
Other
671 stars 93 forks source link

URGENT possible bug in adblock.txt #7802

Closed sintell closed 6 years ago

sintell commented 6 years ago

Hello, I want to report a possible error in https://github.com/MajkiIT/polish-ads-filter/blob/38771e2708b1e34eb1b69f2f91cc508075536cca/polish-adblock-filters/adblock.txt#L4096

Is it intended to block any request that contains wss or proxy as it part?

Currently, this rule applied to such requests: https://i.hh.ru/jsbuild/bloko/blocks/compositeSelection/tagListProxy.h4b93.js https://i.hh.ru/jsbuild/bloko/blocks/compositeSelection/nestedTagListProxy.ha80b https://i.hh.ru/jsbuild/bloko/blocks/compositeSelection/treeSelectorPopupProxy.hca40.js https://i.hh.ru/jsbuild/bloko/blocks/compositeSelection/suggestProxy.ha97c.js

The proxy word there is used as JS file name.

My guess is that this rule is missing domain part in it.

xxcriticxx commented 6 years ago

@sintell i think this was intended for crypto miners

cc @MajkiIT

sintell commented 6 years ago

@xxcriticxx the main question is whether it is intended to block any request that has a word proxy in it or not, regardless of the domain

xxcriticxx commented 6 years ago

@sintell i believe that was that was @MajkiIT intentions to block both proxy and wss

MajkiIT commented 6 years ago

@sintell Thanks, I removed this rule

sintell commented 6 years ago

Thanks a lot :)

github-actions[bot] commented 4 months ago

Ten wątek został automatycznie zablokowany, ponieważ 60 dni po jego zamknięciu nie było żadnej aktywności. Proszę otworzyć nowe zgłoszenie dla powiązanych problemów.