codecov[bot]
commented
4 months ago Codecov Report
Attention: Patch coverage is 97.11684% with 19 lines in your changes are missing coverage. Please review.
Project coverage is 94.97%. Comparing base (
2ebafee) to head (fa44956).
| Files | Patch % | Lines |
|---|---|---|
| api/models/game.py | 92.59% | 10 Missing :warning: |
| api/models/player.py | 95.40% | 4 Missing :warning: |
| api/models/team.py | 97.84% | 2 Missing :warning: |
| api/models/espys.py | 98.07% | 1 Missing :warning: |
| api/models/league.py | 98.03% | 1 Missing :warning: |
| api/models/sponsor.py | 97.82% | 1 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## development #224 +/- ## =============================================== + Coverage 94.94% 94.97% +0.02% =============================================== Files 125 135 +10 Lines 10943 11004 +61 =============================================== + Hits 10390 10451 +61 Misses 553 553 ``` | [Flag](https://app.codecov.io/gh/Major-League-Summer-Baseball/mlsb-platform/pull/224/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Major-League-Summer-Baseball/mlsb-platform/pull/224/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball) | `94.97% <97.11%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball#carryforward-flags-in-the-pull-request-comment) to find out more.:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checklist
Issues closed
Related issues
Description
Model file was getting too big so broke them into separate files To avoid circular dependency had to refactor Team.espys_total to hybrid property and moved get_teams_captain to Team model
Screenshots