Major-League-Summer-Baseball / mlsb-platform

A platform for mlsb
http://mlsb-platform.herokuapp.com/documentation
Apache License 2.0
3 stars 1 forks source link

bugfix(issue-233): captains unable to submit a score #234

Closed fras2560 closed 3 months ago

fras2560 commented 3 months ago

Checklist

Issues closed

Closes #233

Related issues

Description

Captains unable to submit a score due to game not being initialized so was getting undefined when concatenating homerun list causing error on when submitting.

Screenshots

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.12%. Comparing base (d5646b0) to head (c17174a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## development #234 +/- ## =============================================== + Coverage 95.02% 95.12% +0.09% =============================================== Files 137 137 Lines 11196 11214 +18 =============================================== + Hits 10639 10667 +28 + Misses 557 547 -10 ``` | [Flag](https://app.codecov.io/gh/Major-League-Summer-Baseball/mlsb-platform/pull/234/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/Major-League-Summer-Baseball/mlsb-platform/pull/234/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball) | `95.12% <100.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Major-League-Summer-Baseball#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.