search

MajorVictory / Whetstone

A module designed to make applying and customizing themes easier for users and theme authors.
MIT License
10 stars 0 forks source link

Combine OceanBlues and default theme into one theme #19

Open MajorVictory opened 3 years ago

MajorVictory commented 3 years ago

Merge the two themes together. Provide a "Default Colors" colorset

typhonrt commented 3 years ago

Hi @MajorVictory. Thanks for working on Whetstone. It looks like you are getting active with the module again.

I think the Provide a "Default Colors" colorset is the biggest issue I have currently. While you do a good job of overriding Foundry defaults with the theme variables for anything custom in my UI say a special app like the quest tracker in Forien's Quest Log I need to get the app background color which isn't exposed by a default variable. It seems the best way is to mirror all theme variables to a default CSS variable such that they can be accessed generically across any themes defined.

I suppose this could be easiest to implement in Javascript when a theme is activated versus them being manually set in the Theme CSS itself as long as the same / similar variable name pattern is followed. If not then manually setting them in the theme / Main.css works too.

IE I'd like to see all of these CSS variables be assigned to default CSS variables like here. Such that --OceanBlues-bg-color is available by --default-bg-color or another generic name perhaps including whetstone that stays the same across theme switches.

The v0.7.7+ releases of FQL support Whetstone.