Fix a bug in zip64 parsing

Majored / rs-async-zip

An asynchronous ZIP archive reading/writing crate.

MIT License

131 stars 44 forks source link

Fix a bug in zip64 parsing #110

Closed VivekPanyam closed 1 year ago

VivekPanyam commented 1 year ago

This PR fixes an issue with parsing the Zip64 extended information field. See the linked issue for more details.

In the future, it may make sense to restructure the extra field parsing to provide header context (e.g. uncompressed size, compressed size, etc) in a cleaner way, but this seemed to be the simplest change to fix this issue.

Fixes #108

Test plan

Tested locally with large zip files that failed without this change.

Majored commented 1 year ago

@VivekPanyam I've just merged #106 and it looks like that's caused a few conflicts.

Would you be happy to look into those? No worries if not.

VivekPanyam commented 1 year ago

@Majored I fixed the conflicts, retested locally, and updated the PR