search

Majrusz / MajruszLibrary

Library with common code for my Minecraft modifications.
8 stars 6 forks source link

Profiler causes `ConcurrentModification` Exception #21

Closed SiverDX closed 1 year ago

SiverDX commented 1 year ago

For me it's not really important since I rarely use it anyway and it's probably due to some of the other mods I have

Version: 4.2.0

---- Minecraft Crash Report ----
// I bet Cylons wouldn't have this problem.
Time: 2023-06-04 14:52:20
Description: Exception ticking world
java.util.ConcurrentModificationException: null
    at java.util.HashMap.computeIfAbsent(Unknown Source) ~[?:?] {re:mixin}
    at net.minecraft.util.profiling.ActiveProfiler.m_18406_(ActiveProfiler.java:151) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:classloading}
    at net.minecraft.util.profiling.ActiveProfiler.m_7238_(ActiveProfiler.java:123) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:classloading}
    at com.mlib.Utility.profile(Utility.java:139) ~[majrusz-library-1.19.2-4.2.0.jar%23648!/:4.2.0] {re:classloading}
    at com.mlib.gamemodifiers.Contexts.dispatch(Contexts.java:34) ~[majrusz-library-1.19.2-4.2.0.jar%23648!/:4.2.0] {re:classloading}
    at com.mlib.gamemodifiers.contexts.OnCheckSpawn.onSpawnCheck(OnCheckSpawn.java:22) ~[majrusz-library-1.19.2-4.2.0.jar%23648!/:4.2.0] {re:classloading}
    at com.mlib.gamemodifiers.contexts.__OnCheckSpawn_onSpawnCheck_CheckSpawn.invoke(.dynamic) ~[majrusz-library-1.19.2-4.2.0.jar%23648!/:4.2.0] {re:classloading,pl:eventbus:B}
    at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:73) ~[eventbus-6.0.3.jar%23134!/:?] {}
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:315) ~[eventbus-6.0.3.jar%23134!/:?] {}
    at net.minecraftforge.eventbus.EventBus.post(EventBus.java:296) ~[eventbus-6.0.3.jar%23134!/:?] {}
    at net.minecraftforge.event.ForgeEventFactory.canEntitySpawn(ForgeEventFactory.java:193) ~[forge-1.19.2-43.2.11-universal.jar%23792!/:?] {re:mixin,re:classloading}
    at net.minecraftforge.common.ForgeHooks.canEntitySpawn(ForgeHooks.java:1189) ~[forge-1.19.2-43.2.11-universal.jar%23792!/:?] {re:mixin,re:classloading,pl:mixin:APP:enigmaticlegacy.mixins.json:MixinForgeHooks,pl:mixin:A}
    at net.minecraft.world.level.NaturalSpawner.m_47038_(NaturalSpawner.java:184) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,re:classloading,pl:mixin:APP:noseenotick.mixins.json:WorldEntitySpawnerOptimizationMixin,pl:mixin:A}
    at net.minecraft.world.level.NaturalSpawner.m_47045_(NaturalSpawner.java:127) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,re:classloading,pl:mixin:APP:noseenotick.mixins.json:WorldEntitySpawnerOptimizationMixin,pl:mixin:A}
    at net.minecraft.world.level.NaturalSpawner.m_47029_(NaturalSpawner.java:117) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,re:classloading,pl:mixin:APP:noseenotick.mixins.json:WorldEntitySpawnerOptimizationMixin,pl:mixin:A}
    at net.minecraft.server.level.ServerChunkCache.m_8490_(ServerChunkCache.java:356) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:smoothchunk.mixins.json:ServerChunkCacheMixin,pl:mixin:APP:canary.mixins.json:alloc.chunk_ticking.ServerChunkCacheMixin,pl:mixin:APP:canary.mixins.json:world.chunk_access.ServerChunkCacheMixin,pl:mixin:APP:modernfix-common.mixins.json:bugfix.chunk_deadlock.ServerChunkCacheMixin,pl:mixin:A}
    at net.minecraft.server.level.ServerChunkCache.m_201698_(ServerChunkCache.java:310) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:smoothchunk.mixins.json:ServerChunkCacheMixin,pl:mixin:APP:canary.mixins.json:alloc.chunk_ticking.ServerChunkCacheMixin,pl:mixin:APP:canary.mixins.json:world.chunk_access.ServerChunkCacheMixin,pl:mixin:APP:modernfix-common.mixins.json:bugfix.chunk_deadlock.ServerChunkCacheMixin,pl:mixin:A}
    at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:285) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:modernfix-common.mixins.json:perf.cache_strongholds.ServerLevelMixin,pl:mixin:APP:supplementaries-common.mixins.json:ServerLevelMixin,pl:mixin:APP:pluto.mixins.json:fast_entity_access.ServerLevelMixin,pl:mixin:APP:starlight.mixins.json:common.world.ServerWorldMixin,pl:mixin:APP:crafttweaker.mixins.json:common.transform.world.level.MixinServerLevel,pl:mixin:APP:canary.mixins.json:alloc.chunk_random.ServerLevelMixin,pl:mixin:APP:canary.mixins.json:chunk.entity_class_groups.ServerLevelAccessor,pl:mixin:APP:canary.mixins.json:entity.inactive_navigations.ServerLevelMixin,pl:mixin:APP:canary.mixins.json:profiler.ServerLevelMixin,pl:mixin:APP:canary.mixins.json:util.entity_movement_tracking.ServerLevelAccessor,pl:mixin:APP:citadel.mixins.json:ServerLevelMixin,pl:mixin:APP:observable.common.json:ServerLevelMixin,pl:mixin:APP:betterdeserttemples.mixins.json:ServerLevelMixin,pl:mixin:APP:blueprint.mixins.json:ServerLevelMixin,pl:mixin:APP:rottencreatures-common.mixins.json:common.ServerLevelMixin,pl:mixin:APP:create.mixins.json:accessor.ServerLevelAccessor,pl:mixin:APP:fabrication.mixins.json:c_tweaks.alt_absorption_sound.MixinServerWorld,pl:mixin:APP:fabrication.mixins.json:b_utility.item_despawn.MixinServerWorld,pl:mixin:APP:fabrication.mixins.json:i_woina.no_experience.MixinServerWorld,pl:mixin:A}
    at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:866) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
    at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:806) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
    at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:runtimedistcleaner:A,re:classloading,pl:mixin:APP:modernfix-common.mixins.json:perf.thread_priorities.IntegratedServerMixin,pl:mixin:APP:blueprint.mixins.json:client.IntegratedServerMixin,pl:mixin:A,pl:runtimedistcleaner:A}
    at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:654) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
    at net.minecraft.server.MinecraftServer.m_206580_(MinecraftServer.java:244) ~[client-1.19.2-20220805.130853-srg.jar%23787!/:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:A}
    at java.lang.Thread.run(Unknown Source) ~[?:?] {re:mixin}
Majrusz commented 1 year ago

Hi, thanks for the report. I have fixed that here f7d1ba0728ebae36761ba67d50407e3a0b5855c0 and within few days I will release a new version with that fix included