search

Majrusz / MajruszLibrary

Library with common code for my Minecraft modifications.
8 stars 6 forks source link

[1.20.1] Neoforge version of the mods crashing crashing on load; failed to apply Fishinghook mixin #45

Closed Zedrimar closed 8 months ago

Zedrimar commented 8 months ago

https://pastebin.com/C0NT9JpD

Neoforge 47.1.79 Majrusz Lib: 6.1.1 (neoforge) Majrusz Enchantments: 1.10.1 (neoforge) Majrusz's Accessories: 1.3.2

I tested this both on a test instance with just those mods as well as my main mega pack. It will only load with the regular forge version.

Sorry if this is the wrong issues page, log didn't quite say what mod the mixin is from. The log linked above is actually from the AT launcher's logger because the Minecraft log didn't give a full stack trace.

Majrusz commented 8 months ago

Hello, thanks for the report, this bug is extremely odd as the exact same code works fine for forge build. Moreover this code works fine in local development build, but the final .jar file crashes for some magical reason. I will need to investigate it further as at the moment I do not see any fix

Forge code: https://github.com/Majrusz/MajruszLibrary/blob/1.20.X/forge/src/main/java/com/mlib/mixin/forge/MixinFishingHook.java NeoForge code: https://github.com/Majrusz/MajruszLibrary/blob/1.20.X/neoforge/src/main/java/com/mlib/mixin/neoforge/MixinFishingHook.java

Majrusz commented 8 months ago

Okay, nevermind I eventually found a reason why it did not worked 488f8e2efe9f0d374d41cec579b83a754f6fd4c2 and new version with that fix is available, thanks for the report once again!

Zedrimar commented 8 months ago

Damn, all that from one line missing... Well, good to know for my own coding projects. Also, love your mods :)