search

Majrusz / MajruszsAccessories

Minecraft mod that adds new special accessories that make certain aspects of the game more enjoyable.
5 stars 9 forks source link

Game crashes when using "discount Voucher" item and attempting to trade with an Easy Villagers trading block. #25

Closed Clonephaze closed 10 months ago

Clonephaze commented 10 months ago

The Easy Villagers mod has a block called the Trader Block. After looking into both class files and looking at the crash log it seems like the issue might be coming from this line in your TradingDiscount class. The crash log indicates a ClassCastException when attempting to cast a ClientLevel to a ServerLevel, and it specifies that class specifically. Not entirely sure if that's something that should be fixed in the TradingDiscount class or in the OnTradesUpdated class from your library mod or an entirely different class. Never actually worked with java or I'd try fixing it and sending a PR lol. Let me know if you need other info.

Also the issue was first reported here, as far as I know.

Majrusz commented 10 months ago

Hello, thanks for the report. I fixed it on my side here ec62f0319d1445c743e1bd80e3980bd9633bbb60 and soon will release new version