Majrusz / MajruszsAccessories

Minecraft mod that adds new special accessories that make certain aspects of the game more enjoyable.
5 stars 9 forks source link

[Forge 1.20.1] Re: Incompatibility with Aquaculture 2 #59

Closed LilChromie closed 4 months ago

LilChromie commented 4 months ago

Upon making sure I am on the latest version (both accessories and library), I ran a few tests and discovered a few things:

In the neoforge version, (majrusz-library-neoforge-1.20.1-7.0.6), nothing works when using aquaculture 2 fishing rods. The accessories do not drop, and when equipped they do not work (tested by boosting the accessories to drop and activate 100% of the time, and tested individually with the base items, angler rune, and soul of minecraft).

In the forge version (majrusz-library-forge-1.20.1-7.0.6, ran using the same version of neoforge as the prior tests) there is some compatibility, but there are still issues. The accessories are dropping when using aquaculture rods, and the double drops function properly. However, the fishing time reduction does not work with aquaculture rods, and the purple particle effects caused by the rune do not appear. I cannot confirm if the luck boost works or not, because despite increasing it to 16 I could not notice a difference when using it with either vanilla or aquaculture mods, however I might just not know how luck works. (Again, tested by boosting the accessories to drop and activate 100% of the time, and tested individually with the base items, angler rune, and soul of minecraft).

Originally posted by @LilChromie in https://github.com/Majrusz/MajruszsAccessories/issues/57#issuecomment-2079967589

LilChromie commented 4 months ago

Upon further inspection, the purple particles show up when reeling the fish in using an aquaculture rod, but not when casting.