[1.20.1] Fabric - Incomaptibility with Tinkerer's Smithing

Majrusz / MajruszsProgressiveDifficultyMod

Minecraft modification that progressively increases the game difficulty over time.

21 stars 29 forks source link

[1.20.1] Fabric - Incomaptibility with Tinkerer's Smithing #205

Closed FLSoz closed 10 months ago

FLSoz commented 10 months ago

Fabric 1.20.1

sample log: https://mclo.gs/GllhrFf

It's crashing here: https://github.com/sisby-folk/tinkerers-smithing/blob/46db139f9236992501f8b763a42f301f95448e33/src/main/java/folk/sisby/tinkerers_smithing/TinkerersSmithingLoader.java#L282

Likely because of this: https://github.com/Majrusz/MajruszsProgressiveDifficultyMod/blob/544a629793cfb2fb7e18107408259646aad48603/common/src/main/java/com/majruszsdifficulty/items/CustomArmorMaterial.java#L96

Why is getName set to client only?

Majrusz commented 10 months ago

Hello, thanks for the report. It seems like this @OnlyIn annotation is a leftover from older minecraft versions and it is not required anymore, I have fixed it here 00e7c35438d5c1118ec42a4712a759494cf38567 and will include this fix with the next 1.9.7 release