MakD / zombie-release

A theme for Jellyfin 10.9.x combining the best from the Public Themes
51 stars 4 forks source link

Icons not visible on my QHD monitor (2560 x 1440) #1

Closed xd003 closed 4 months ago

xd003 commented 4 months ago

As implied from the title, the icons throughtout jellyfin media player on my QHD monitor appear to be broken. Although the theme appears to be fine when jellyfin web is viewed on the browser. Also i would like to point out that the icons appear a bit too large than ideal in browser , ideally that could be fixed as well.

Screenshot from browser image

Screenshots from jellyfin media player image

image

MakD commented 4 months ago

Somehow the jellyfin media player is messing with the icon import as I can sense. It's an easy fix. I'll get it done 👍

MakD commented 4 months ago

As implied from the title, the icons throughtout jellyfin media player on my QHD monitor appear to be broken. Although the theme appears to be fine when jellyfin web is viewed on the browser. Also i would like to point out that the icons appear a bit too large than ideal in browser , ideally that could be fixed as well.

Screenshot from browser image

Screenshots from jellyfin media player image

image

Do you have your "force enable web client enabled". If not can you try and check after enabling it.

xd003 commented 4 months ago

I ticked the option which said - "Force external web client" in client settings. The icons are still broken

MakD commented 4 months ago

I ticked the option which said - "Force external web client" in client settings. The icons are still broken

Strange. It's working on my end with the icons being pulled normally. You are using which release? Your import url should say that.

xd003 commented 4 months ago

Strange. It's working on my end with the icons being pulled normally. You are using which release? Your import url should say that.

Here's my whole custom css

@import url('https://cdn.jsdelivr.net/gh/MakD/zombie-release@latest/zombie-min-git.css');
@import url('https://cdn.jsdelivr.net/gh/stpnwf/ZestyTheme@latest/colorschemes/green.css');

/*if the logo is present on the details page and loaded hide the title so it doesnt duplicate and look weird*/
#itemDetailPage .itemName.infoText.parentNameLast > bdi:nth-child(1) {display: none;}
.hide+.detailPageWrapperContainer .itemName > bdi:nth-child(1) {display: block !important;}
/*the same but for the single episodes link back title*/
#itemDetailPage .parentName > bdi:nth-child(1) {display: none;}
.hide+.parentName > bdi:nth-child(1) {display: block !important;}
MakD commented 4 months ago

Strange. It's working on my end with the icons being pulled normally. You are using which release? Your import url should say that.

Here's my whole custom css

@import url('https://cdn.jsdelivr.net/gh/MakD/zombie-release@latest/zombie-min-git.css');
@import url('https://cdn.jsdelivr.net/gh/stpnwf/ZestyTheme@latest/colorschemes/green.css');

/*if the logo is present on the details page and loaded hide the title so it doesnt duplicate and look weird*/
#itemDetailPage .itemName.infoText.parentNameLast > bdi:nth-child(1) {display: none;}
.hide+.detailPageWrapperContainer .itemName > bdi:nth-child(1) {display: block !important;}
/*the same but for the single episodes link back title*/
#itemDetailPage .parentName > bdi:nth-child(1) {display: none;}
.hide+.parentName > bdi:nth-child(1) {display: block !important;}

Since I cannot reproduce the issue, the best I can do is de-bundle the custom icons included in the theme. But before I do that, can you check with some other custom icons being directly added as custom CSS and is the JPM still acting up in rendering them? You can find some in https://github.com/prayag17/Jellyfin-Icons

xd003 commented 4 months ago

Even with a custom icon pack imported directly, jmp is still having problems rendering them. Lemme reinstall jmp and see how it goes

xd003 commented 4 months ago

Update - still didn't help. i am gonna try a different windows machine and see how it goes there. On another note, don't you think removing the white borders around items in the navbar ( home/favourites) and on the top right would be a better thing to do. I have had all my users like this theme quite a lot except just that border

Will also get my other friends to test this out on their systems as well to help pinpoint what might be causing it

MakD commented 4 months ago

Update - still didn't help. i am gonna try a different windows machine and see how it goes there. On another note, don't you think removing the white borders around items in the navbar ( home/favourites) and on the top right would be a better thing to do. I have had all my users like this theme quite a lot except just that border

Will also get my other friends to test this out on their systems as well to help pinpoint what might be causing it

Sure that will help.

Btw for the input, you can remove the border by adding this to your custom CSS

.headerRight, .headerTabs { border-width: 0px !important; }

xd003 commented 4 months ago

i am not sure how but randomly the icons started appearing fine inside jmp, i don't face the issue anymore