Makanz / chartjs-plugin-trendline

This plugin draws an linear trendline in your Chart. Made for Chart.js > 3.0
MIT License
80 stars 57 forks source link

Added support for v3.x of chartJS #56

Closed jmm13 closed 2 years ago

jmm13 commented 2 years ago

Added a few lines to make this plugin support ChartJS v3.x (I tested it with 3.4.1).

This should also take care of the Cannot read property 'register' of undefined issue #54

This is my first time ever trying to contribute to a github project, so I apologize if I did something wrong.

jasonlutterloh commented 2 years ago

Please merge this. I can confirm it works via a forked copy with the changes:

jmm13 commented 2 years ago

I assume you're asking Makanz to merge- I just checked and it says "Only those with write access to this repository can merge pull requests."

Again, apologies for the newbie questions.

jasonlutterloh commented 2 years ago

I assume you're asking Makanz to merge- I just checked and it says "Only those with write access to this repository can merge pull requests."

Again, apologies for the newbie questions.

Yes haha Sorry for any confusion

Makanz commented 2 years ago

Dose this update work with 2.X or only 3.X and above?