search

Makar8000 / ACT-Discord-Triggers

An ACT plugin for routing audio to discord
50 stars 13 forks source link

Discord Triggers randomly disconnects #66

Open ChaosLegionaire opened 4 years ago

ChaosLegionaire commented 4 years ago

Both my friend and I have been having issues where the Discord Triggers bot will just randomly disconnect from Discord. It will be doing callouts just fine like normal and then you'll just hear the Discord disconnect sound and the bot is gone.

There's nothing consistent that I can find as to when it disconnects. Sometime I'm in fights that don't even have triggers OR it will be after a fight is cleared when the bot will just disconnect.

Like I said, both my friend and I have been having this issue and we have completely separate installs of ACT so I'm not really sure what the common cause would be.

[Audio #1] Connected Joined channel: General Chat Playing TTS for text: Provoke: Leo' Playing TTS for text: Provoke: Oceanic Playing TTS for text: Living: Oceanic Playing TTS for text: Provoke: Oceanic [Gateway] Disconnecting [Gateway] Disconnected [Audio #1] Disconnecting [Audio #1] Disconnected [Gateway] Connecting [Audio #1] Connecting [Audio #1] Disconnecting [Audio #1] Disconnected [Gateway] Failed to resume previous session [Gateway] Disconnecting [Gateway] Disconnected [Gateway] Connecting [Gateway] Connected Bot in ready state. Populating servers... Found 1 discord server(s). Found 8 available voice channel(s) for Lowered Graphics [Gateway] Ready [Audio #2] Connecting [Audio #2] Connected Joined channel: General Chat

Makar8000 commented 4 years ago

This looks like general discord api downtime. How often does it happen?

ChaosLegionaire commented 4 years ago

Happens every time we use it for like the last month or more. It disconnects at least once an hour.

Update: It just disconnected again as I was testing it with E8N. Just DCed at the last 5% of the fight.

Playing TTS for text: Out Playing TTS for text: Stand in a tower Playing TTS for text: Stand in a tower Playing TTS for text: Stand in a tower Playing TTS for text: Out, then in [Gateway] Disconnecting [Gateway] Disconnected [Audio #1] Disconnecting [Audio #1] Disconnected [Gateway] Connecting [Audio #1] Connecting [Audio #1] Disconnecting [Audio #1] Disconnected [Gateway] Failed to resume previous session [Gateway] Disconnecting [Gateway] Disconnected [Gateway] Connecting [Gateway] Connected Bot in ready state. Populating servers... Found 1 discord server(s). Found 8 available voice channel(s) for Lowered Graphics [Gateway] Ready

(I don't know if there is a better error log for more detail as to what the cause might be. This is just the only one I have found.)

Makar8000 commented 4 years ago

Once an hour is a bit much unless it's during some API hiccups (there's been a few in the past few weeks). Is it an everyday thing? Do you happen to have a list of recent days? I am looking at your log and it definitely seems like connection issues. Are you using the latest version?

ChaosLegionaire commented 4 years ago

I am using the latest build 1.0.2.0 but it was also doing it with the last build too. Was also careful to make sure I removed all of the files from the older version.

We raid Tuesday, Thursday and Sunday of every week and it has happened multiple times each night for quite a while now.

Also a fellow raider has been having the exact same issue. Which leads me to believe that it's not specific to my network or my particular install. Perhaps it's a conflict or something? idk

I-Am-Buggy commented 4 years ago

I can confirm, this is happening to me as well on the previous and current version. It's been happening for only the last 4-6 weeks. I figured it was a trigger bug, but then I realized it's only the discord bot that disconnects. All normal call outs continue to work for me locally.

ChaosLegionaire commented 4 years ago

After messing around with a few settings I thought I had randomly fixed the problem after it worked 1 night for 3 hours straight. But it has happened again both Thursday and Tonight (Sunday).

Playing TTS for text: put seeds on dirt Playing TTS for text: Spread Playing TTS for text: Kill Extra Add [Gateway] Disconnecting [Gateway] Disconnected Error playing TTS [Audio #2] Disconnecting The operation was canceled. [Audio #2] Disconnected Error playing TTS A task was canceled. [Gateway] Connecting [Audio #2] Connecting [Audio #2] Disconnecting [Audio #2] Disconnected [Gateway] Disconnecting [Gateway] Disconnected [Gateway] Connecting [Gateway] Failed to resume previous session [Gateway] Connected Bot in ready state. Populating servers... Found 1 discord server(s). Found 8 available voice channel(s) for Lowered Graphics [Gateway] Ready Playing TTS for text: Left

Breadumi commented 4 years ago

I'm also having similar issues. The disconnects happen randomly. Sometimes it'll be fine for a couple hours, sometimes it disconnects after 30 minutes. Every time this happens, the bot gets kicked from the channel and I have to add it back in. Trigger playback is completely gone though. I end up having to restart ACT in order for the playback to function again.

bot_disconnect1

djc5166 commented 4 years ago

Same here, disconnects all the time. Sometimes it's fine for hours in a row, sometimes it disconnects multiple times in an hour.

The discord triggers log doesn't seem to have any errors, in fact it seems to think it is still connected to the discord server.

Also leave channel / connect isn't enough to fix it when it disconnects, it will rejoin the channel but will not play any of the TTS commands. The only way to fix it is to close/restart ACT and join the discord channel again.

Merkava2k15 commented 4 years ago

Can confirm that I have been having this issue for quite a bit now as well. I have used this plugin for a long time and about a month ago I noticed my bot would randomly DC from discord without a warning while no errors displayed on the bots log, the only way to get it to work is to restart ACT entirely and have the bot rejoin. My plugin was super oudated (hadn't bothered updating it for a long time) so I updated it to the most recent version and the problem persists. How frequently this happens seems to be entirely random as I have gone entire raid nights without the issue and others seeing it multiple times. This also happens to a friend who recently installed the bot (following the installation guide).

Makar8000 commented 4 years ago

When I get some time I'll probably try to do a small rewrite with a different discord api and see if that helps

djc5166 commented 3 years ago

Ever make any progress with this issue?

Makar8000 commented 3 years ago

Not yet. I got some insight from some other developers on what could be causing the problem though, so I have some ideas to try. I am really not sure when I'll get to it though, as I've been occupied with either playing the game or other projects.

Blazefyre0385 commented 2 years ago

Is anyone still maintaining this plugin? It has been over a year since the last reply and this issue is still ongoing. Looking for any kind of update that may help resolve the random disconnects.

Makar8000 commented 2 years ago

Is anyone still maintaining this plugin? It has been over a year since the last reply and this issue is still ongoing. Looking for any kind of update that may help resolve the random disconnects.

Not really. I plan to rewrite it once / if ACT migrates to .NET Core or 5+, which will fix the issue. But for now... PRs are appreciated as I'm not sure what to do with to fix it with the current Discord API I'm using.

djc5166 commented 2 years ago

Is anyone still maintaining this plugin? It has been over a year since the last reply and this issue is still ongoing. Looking for any kind of update that may help resolve the random disconnects.

I made a fork and tried updating all the APIs to the latest versions, you can try this one out if you want, I haven't noticed any DC's yet. It's hard to really tell since it's so intermittent.

ACT_DiscordTriggers.zip

https://github.com/djc5166/ACT-Discord-Triggers

Makar8000 commented 2 years ago

Thanks @djc5166 - I merged your changes and also updated the API to the version released last week.

djc5166 commented 2 years ago

Still disconnects for me sometimes, but now it is more like once every few days instead of once every few hours. Curious on how it is working for anyone else.

I haven't had a ton of time to learn discord.net but I am working on it :D

ChaosLegionaire commented 2 years ago

Still happens. Except now it crashes every 90 minutes instead of every 60 minutes.