Makar8000 / ACT-Discord-Triggers

An ACT plugin for routing audio to discord
50 stars 14 forks source link

Crashes ACT if multiple custom triggers occur at the exact same time? #8

Closed Crevox closed 6 years ago

Crevox commented 7 years ago

My ACT crashes if the bot is in a channel and attempts to react to two triggers at the same time. At least, I'm pretty sure that is what causes it, and my ACT has only ever crashed with the bot in the channel.

My case:

Trigger R="A1 activates and begins to emit heat." SD="middle big ice" ST="3" CR="F" C="Frontlines" T="F" TN="" Ta="F" Trigger R="A2 activates and begins to emit heat." SD="north big ice" ST="3" CR="F" C="Frontlines" T="F" TN="" Ta="F" Trigger R="A3 activates and begins to emit heat." SD="southeast big ice" ST="3" CR="F" C="Frontlines" T="F" TN="" Ta="F" Trigger R="A4 activates and begins to emit heat." SD="southwest big ice" ST="3" CR="F" C="Frontlines" T="F" TN="" Ta="F"

This works just fine MOST of the time, but rarely 2 big ice spawn at the exact same time, and when this happens, ACT will crash, and the bot will also spit out gibberish into tts.

seth-rah commented 7 years ago

Can confirm, have had it do the same on my system.

Any chance there is a debug version that can log to a file? I know that ACT will call them out on top of each other which is probably not optimal, but having a pause between each call would be pretty neat. It's likely the main problem is with ACT to implement this though.

megaoka commented 6 years ago

This is a known issue with the Discord API. Makar is looking for help regarding this. ACT.TTSYukkuri supposedly circumvents this issue..?

Please see: https://github.com/Makar8000/ACT-Discord-Triggers/issues/4

Makar8000 commented 6 years ago

Releasing a major update soon that should fix this.