Plugin review

[gilbitron]

Hey @jamesckemp @patrickposner. After giving the plugin an initial once over, here are some of the things I think need fixed/improved before launch:

• [x] We should add a link to the account settings to create an API key
• [x] The API doc link needs updated to point to the API docs
• [x] When entering an invalid API key we should show a validation error message
• [x] When entering a valid API key we should show a success message
• [x] The "Start selling today" link should probably open in a new window?

Also, once the API key has been successfully entered we should stop showing it to prevent other WP users logging in and being able to see/steal the API key. For this state, I suggest we replace the input with a read-only input that displays a blanked out key showing the last X chars (e.g. ****************1234) and change the button to "Disconnect from Lemon Squeezy" or similar.

• [x] The LS button icon should be the LS lemon
• [x] The LS button block needs some styling tweaks
• [x] The "customize text link" should probably be something like "Button text" and should indicate that it's a required field
• [x] "Use checkout overlay?" could probably do with a brief help text explaining what the setting does
• [x] The "Uh oh!" message should link to the settings page

[patrickposner]

• [x] show only the last characters of the API key (maybe with a custom React component?)

[gilbitron]

@patrickposner I've just had a look at your updates and the API key input still isn't quite right:

• [x] "There was an error validating your license key" currently shows when typing in the input. It should only show after clicking save with an invalid key.
• [x] When the license key is valid, the save button does nothing. I think we should hide the save button completely when the key is valid.
• [x] If I click "Reset license key" and then refresh the page, the state is reset. Clicking "Reset license key" should save the settings as well.
• [x] We should disable auto-complete on the API key input.

One other minor thing I noticed: the settings link in the "Uh oh" error message incorrectly uses "https://" for the URL on my localhost. I'm not sure how lsData.settings_url is being populated, but it should use the URL scheme of the site.

[gilbitron]

One other thing I've just realised, the products dropdown in the block is loading all products across all of the Lemon Squeezy stores that belong to the user. I think we should add a second "stores" dropdown above the products dropdown if the API key has access to multiple stores. That way products can be filtered by store.

[gilbitron]

@patrickposner I've got the OAuth implementation ready for review now. So you should ignore my comment above regarding changes to the API key implementation and just review the OAuth PR #5 instead.

[patrickposner]

I close this now.

Added an issue for the store option here: #7