search

Make-md / makemd

http://www.make.md
MIT License
1.1k stars 39 forks source link

[BUG] `Spaces` view hijacks `files` commands from default explorer #223

Open Enteleform opened 12 months ago

Enteleform commented 12 months ago

Expected

Files: Show file explorer and Files: Reveal current file in navigation commands open the default explorer view.

Actual

Both of those commands open the Spaces view.

jp-cen commented 12 months ago

There’s a setting called compatibility mode in the navigator settings that lets you set files as the main navigation listener

Get Outlook for iOShttps://aka.ms/o0ukef

From: Enteleform @.> Sent: Friday, November 17, 2023 12:09:42 PM To: Make-md/makemd @.> Cc: Subscribed @.***> Subject: [Make-md/makemd] [BUG] Spaces view hijacks files commands from default explorer (Issue #223)

Expected

Files: Show file explorer and Files: Reveal current file in navigation commands open the default explorer view.

Actual

Both of those commands open the Spaces view.

— Reply to this email directly, view it on GitHubhttps://github.com/Make-md/makemd/issues/223, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFHKNXSHLNZIGHPU553XFDYE6K5NAVCNFSM6AAAAAA7QC7HCSVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE4TSNJYGQ2DOMI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Enteleform commented 12 months ago

Thanks, that worked to restore the expected functionality.

Compatibility Mode and its current description are rather vague and don't afford the user any expectations of how this feature might affect default functionality and interactions with other plugins.

The overriding behavior makes more sense as an opt-in feature rather than opt-out. Or even better, why not just provide a separate command so that both default and extended functionalities can be used without creating unexpected behavior? For example, by adding a Reveal current file in Spaces command to accompany the already existing Open Spaces command.