Make-md / makemd

http://www.make.md
MIT License
1.03k stars 33 forks source link

Blink Search Problem #310

Closed lifehaschanged closed 1 month ago

lifehaschanged commented 4 months ago

Hi,

Thanks for the Blink search. It's working fine in a sandbox vault without problems.

But in my main vault with many plugins enabled I have this problem:

  1. I type one letter in the text input box inside the blink prompt
  2. It's automatically activating the first search result in the background
  3. The text input cursor inside the blink prompt isn't focused anymore and I have to click again inside the text input bar after every letter. This makes searching with Blink nearly impossible for me.

Can you tell me what other plugins or custom make.md settings could be interfering with the Blink search for narrowing down the problem here? Sadly no error is visible in the developer console.

Thanks.

jp-cen commented 4 months ago

Thanks for reporting. Blink is part of the next set of polishes as part of the preparation for the stable release so these issues will be addressed soon.

Get Outlook for iOShttps://aka.ms/o0ukef


From: lifehaschanged @.> Sent: Saturday, April 27, 2024 1:17:59 PM To: Make-md/makemd @.> Cc: Subscribed @.***> Subject: [Make-md/makemd] Blink Search Problem (Issue #310)

Hi,

Thanks for the Blink search. It's working fine in a sandbox vault without problems.

But in my main vault with many plugins enabled I have this problem:

  1. I type one letter in the text input box inside the blink prompt
  2. It's automatically activating the first search result in the background
  3. The text input cursor inside the blink prompt isn't focused anymore and I have to click again inside the text input bar after every letter. This makes searching with Blink nearly impossible for me.

Can you tell me what other plugins or custom make.md settings could be interfering with the Blink search for narrowing down the problem here? Sadly no error is visible in the developer console.

Thanks.

— Reply to this email directly, view it on GitHubhttps://github.com/Make-md/makemd/issues/310, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAFHKNQHEIMTOUTQEIRZH63Y7PMUPAVCNFSM6AAAAABG4HX27GVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DOMJQGYYDGMQ. You are receiving this because you are subscribed to this thread.Message ID: @.***>

lifehaschanged commented 4 months ago

Good to hear. I'm already looking forward to the next versions.

lifehaschanged commented 4 months ago

Thanks for the latest update. Unfortunately it doesn't solve this issue.

But I've finally found the plugin that's causing all the problems I described in my first post. Please open a sandbox vault and install MAKE.md + Excalidraw, and see if you can reproduce my problems in the first post. Plus the additional problem (Excalidraw enabled) that Blink doesn't focus the note in the main window after doing a double click or pressing the enter key inside Blink.

I found some other bugs in the console while using Blink. First one seems to be connected to my first bug or some filtering bugs (when a filter was active), but I can't reproduce it:

2024 5 6

Second one I don't know what's causing it (but occurs while using Blink):

2024 5 6 2
lifehaschanged commented 4 months ago

I got the same problems in Blink when the plugin "Daily Notes Editor" is activated.

lifehaschanged commented 3 months ago

I am grateful to you and do not want to be a burden, I hope you can solve this. Blink, thank God, works with almost all of my tested plugins. However, I have even identified a third case where, when activated, it does not work in Blink: https://github.com/Quorafind/Obsidian-Float-Search Thank you for all your efforts and I would be happy to receive an update to be able to use Blink.

jp-cen commented 3 months ago

Thanks for the feedback, it's highly appreciated. Third-party plug-in compatibility will be looked at soon, right now the focus is getting the core plug-in stable and performant.

lifehaschanged commented 3 months ago

Thank you. I also think it is very sensible to make the core features more error-free. Here are 3 things I noticed that are still relevant for Blink:

When editing a note in Blink:

The suggestion box for links with [[]] is displayed behind the Blink interface. The suggestion box for tags (#) is not displayed.

In the search input:

The Tab key does not switch to the edit view.

lifehaschanged commented 3 months ago

The above-mentioned plugin (Floating Search) has an important command, namely "Search obsidian globally". This opens a popup that provides a similar search to Blink (unfortunately, it cannot search or edit Make.md Spaces). In this Floating Search popup, you can jump to editing the note by pressing the tab key, but only if you have previously pressed the down arrow key on the keyboard (which selects the first search result).

big-chungus69420 commented 3 months ago

Thanks for the latest update. Unfortunately it doesn't solve this issue.

But I've finally found the plugin that's causing all the problems I described in my first post. Please open a sandbox vault and install MAKE.md + Excalidraw, and see if you can reproduce my problems in the first post. Plus the additional problem (Excalidraw enabled) that Blink doesn't focus the note in the main window after doing a double click or pressing the enter key inside Blink.

I found some other bugs in the console while using Blink. First one seems to be connected to my first bug or some filtering bugs (when a filter was active), but I can't reproduce it:

2024 5 6

Second one I don't know what's causing it (but occurs while using Blink):

2024 5 6 2

I'm having the exact same issue and the moment I disable excalidraw, the issue gets resolved. But I need excalidraw because I use Obsidian for taking notes, so ig I have to disable blink instead.

jp-cen commented 1 month ago

Excalidraw compatibility issues should be fixed