MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
322 stars 148 forks source link

Add Covid-19 Dungeon #110

Closed ghost closed 3 years ago

ghost commented 3 years ago

Hello friends,

I added a new dungeon which has the Covid-19 theme. But, I am lost in it, confused and I don't know what to write next 😭 . Can someone complete this for me? I can help as well.

Created to Address #103, but couldn't finish

I don't have a skill of story writing, so I think I am unable to do this. But, I will work on other areas 😐.

Thanks for understanding.

ming-tsai commented 3 years ago

Hi @paulsonjpaul, you could let it open, and jump into this file english/normal-dungeon/4/0.md

ghost commented 3 years ago

Alright. I didn't know about this. There are many files in this repo! I will check it out when I am free.

Can you please add some labels to this PR (help wanted, etc.), so that some newcomers will be driven here and do some contributions?

FukurouMakoto commented 3 years ago

Love the idea on this lol. Would it be okay if I work on this issue if no new people have jumped on it after a couple of weeks maybe? I like the idea of it but I really want to have some new people pick it up and run with it.

ghost commented 3 years ago

@FukurouMakoto, yes. You can take this if no one is interested in this after a couple of weeks.

ghost commented 3 years ago

I have an idea. How about I add a new issue and link it to this PR? That might bring some new people.

ghost commented 3 years ago

I have another question. How can a new person (non-member of this organization) work on this PR? Only members can edit this PR, right?

ming-tsai commented 3 years ago

I have an idea. How about I add a new issue and link it to this PR? That might bring some new people.

Yes you could do it

ming-tsai commented 3 years ago

I have another question. How can a new person (non-member of this organization) work on this PR? Only members can edit this PR, right?

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

ghost commented 3 years ago

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

Will that allow a non-member to edit this Pull Request? I am talking about this specific PR, not the whole repo.

ming-tsai commented 3 years ago

You could open an issue and add beginner, good first issue, and help wanted labels, this repository is configurated for it

Will that allow a non-member to edit this Pull Request? I am talking about this specific PR, not the whole repo.

Yes, the issue will be published on up-for-grabs

ghost commented 3 years ago

Ok. Can you please open the issue? I don't know what to write as steps.

Arsenic-ATG commented 3 years ago

Hello friends,

I added a new dungeon which has the Covid-19 theme. But, I am lost in it, confused and I don't know what to write next 😭 . Can someone complete this for me? I can help as well.

Created to Address #103, but couldn't finish

I don't have a skill of story writing, so I think I am unable to do this. But, I will work on other areas 😐.

Thanks for understanding.

@paulsonjpaul new dungeons are not meant to be complete, in fact the purpose of this repository to exist is to help new comers get familiar with the GitHub environment by doing small contributions if you want, you can let the changes done so far be merged in the main repo so that other people can also expand the story on their own level and not have to change your pull request again and again.

Also if your pull request is still work in progress then it is much better to convert the pull request to a draft than adding a (WIP) tag in the title as then it will be safe from accidental merges 🙂.

ghost commented 3 years ago

Thanks @Arsenic-ATG . I had planned about making the PR a draft, but was not sure what it would do.

if you want, you can let the changes done so far be merged in the main repo so that other people can also expand the story on their own level and not have to change your pull request again and again.

Ok. That seems a good idea. After merging, I will open an issue so that new users will be able to complete it.

@ming-tsai and other members, can you review this and merge?

ghost commented 3 years ago

@Arsenic-ATG please see my reply to your comments

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ming-tsai commented 3 years ago

Nice work @paulsonjpaul and @Arsenic-ATG