search

MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
322 stars 148 forks source link

Link not found #115

Closed codely8 closed 3 years ago

codely8 commented 3 years ago

I started the game, i ended up in a page where it shows like this image When i click the link it took me to 404 page of github. Please take a note.

ghost commented 3 years ago

Looks like the issue is with wrong relative url. If you want, you can fix it.

Just fork the repo, create a new branch, edit the WIP.md file. Change the link from ../../../README.md#contribution-guidelines to ../../README.md#contribution-guidelines

ghost commented 3 years ago

Please make sure you read the contribution docs as well before doing this. It can be found in the readme file.

codely8 commented 3 years ago

I read the docs and change the URL. it worked fine.

ghost commented 3 years ago

Then you are ready to make a pull request 👍

codely8 commented 3 years ago

I did it in the fork repo.

ghost commented 3 years ago

Did you make a Pull Request? If not, please do it. Then only we can merge it into this repo.

ghost commented 3 years ago

I see that you created a pull request in your fork. That is not the way of doing it. Please create a Pull Request again and make sure you point the base branch to this repo.

ming-tsai commented 3 years ago

Hi @Codely-F, is this issue is solved on #116 ?

ghost commented 3 years ago

Right now the hyperlink points to #112 based on @Arsenic-ATG's PR. Nice job anyway @Codely-F .

ming-tsai commented 3 years ago

Ok, thanks @paulsonjpaul. This issue will be closed, if the bug is persisted you could reopen it