MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
322 stars 148 forks source link

Add more dungeons, rooms or floors #128

Open ming-tsai opened 3 years ago

ming-tsai commented 3 years ago

It'd be awesome to have a lot of the dungeons, rooms, or floors, so the game could be more fun 😜

🐞 Problem Currently, we have only a bunch of dungeons, rooms, or floors in the project

🎯 Goal Have a lot of dungeons, rooms, or floors from the diverse games.

💡 Possible solutions Add new a new dungeon, rooms, or floors.

How to make it? Check out Contribution Guidelines

📋 Steps to solve the problem

  1. Comment below about what you've started working on.
  2. Add, commit, push your changes
  3. Submit a pull request and add this in comments - Addresses #
  4. Ask for a review in the comments section of the pull request
  5. Celebrate your contribution to this project 🎉
tonyren-card commented 3 years ago

Hi, can I help with this issue? I would like to make a pull request.

ming-tsai commented 3 years ago

Yes @antonyren-carleton, I will wait for your pull request

tonyren-card commented 3 years ago

@ming-tsai And can you please check my discussion post regarding my inquiry #152

ming-tsai commented 3 years ago

@ming-tsai And can you please check my discussion post regarding my inquiry #152

Ok, I'll check it out

tonyren-card commented 3 years ago

Hi! I would like to add some rooms for the COVID-19 dungeon, if this is okay for you.

ming-tsai commented 3 years ago

Okis, I'm waiting for your pull request 🙂

tonyren-card commented 3 years ago

Okis, I'm waiting for your pull request 🙂

Here is my pull request #155 please review thanks :)

hkumar0132 commented 3 years ago

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

ming-tsai commented 3 years ago

@ming-tsai Would be good to have time travel based dungeons. I am adding one but it's very basic right now.

Yes, this repo is as you say

hkumar0132 commented 3 years ago

time-travel dungeon #165

haddeeann commented 3 years ago

I made a pr with some .md pages added to the time travel section of the dungeon.

SiliconSalvation commented 3 years ago

May I contribute?

ming-tsai commented 3 years ago

May I contribute?

Yes @kazuma2448

Karguel1995 commented 3 years ago

I would like to work on Time-Travel year 1800, because it's looking sooo poor :D I already prepared some rooms and floors, they are waiting to commit.

#175

hkumar0132 commented 3 years ago

Very creative @Karguel1995

SiliconSalvation commented 3 years ago

I worked on improving grammar on floor 6 in English normal dungeon, files 1-4. I think the result is more enjoyable for English readers.

178

gonuma commented 2 years ago

I would like to add more rooms/floors in the future, but for now I added a short sub-story to English>normal-dungeon!

193

Manas-Tiwari commented 2 years ago

Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors. so can i work on this issue ? Thank you, waiting for your response.

ming-tsai commented 2 years ago

Hi @ming-tsai, I found sci-fi-dungeon incomplete and would like to create/extend it to more rooms/floors. so can i work on this issue ? Thank you, waiting for your response.

Yes, I will wait for your pull request.

Manas-Tiwari commented 2 years ago

@ming-tsai sorry to ping you but can you please review my pr #198. Tysm.

crisjumbo commented 2 years ago

I already did the room. Now I don't have any idea how to make the PR properly. What happened if the original repo is updated in comparison to mine master_branch? 🍡

NS007-dev commented 2 years ago

@srcristofher do you mean what happens if the original repo updates, but your fork is outdated?

crisjumbo commented 2 years ago

Exactly. I meant that :)

NS007-dev commented 2 years ago

@srcristofher so when the main repo updates, and your forked repo is outdated, all you need to do is go to git bash and give the following commands: if you are not already in the repo environment: cd markdown-dungeon To get upstream/update your fork, you git pull to pull all the new changes from the original repo, to your forked one. git pull

How to do it online:

At the top, you will see this: image

just press fetch upstream, and the green button.

Need any more help, feel free to ask.

mohitahlawat2001 commented 2 years ago

hi , please assign me i want to work

ming-tsai commented 2 years ago

hi , please assign me i want to work

Hi @mohitahlawat2001, This issue is not assignable, you just open a pull request and mention it on this issue

catherinepham commented 2 years ago

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

NS007-dev commented 2 years ago

Hello, I would like to contribute to this issue by adding more floors and rooms to the time-travel dungeon. However, when I try to push, Github says that I don't have write access to the repo and should contact the repo admin.

Have you forked the repo first @catherinepham ? Sorry I just saw the pr. Thank you.

catherinepham commented 2 years ago

Thank you for responding! Are you able to review the pr for me?

ming-tsai commented 2 years ago

Thank you for responding! Are you able to review the pr for me?

Hi @catherinepham, Your pull request @ hkumar0132 will be review it

JCHDeveloperGuy commented 2 years ago

I'm a new contributor and I'm thinking about adding a dungeon. I will send a pull request when I'm done.

BranAndSceolan commented 2 years ago

It is my first time using GitHub for contributing to an open source project. I have read the README and some guides to GitHub.

Am I correct in assuming following workflow:

0 Find issue you want to work on 1 Comment that you want to work on this issue 2 Fork the repository 3 Make a new branch in your fork 4 work on the new branch 5 create a pull request 6 comment what you did and in which pull request

I have made some spelling edits in pull request #216. If these (and the way I did them) are okay, i would try to make a new merge request for adding some rooms next.

BranAndSceolan commented 2 years ago

Added some rooms for the normal-dungeon: #217 Also tried to add to the README: #218

Himanshu2561 commented 2 years ago

I would also like to create some rooms and floors for the dungeon, I will be raising pr in the comming time.

ShatilKhan commented 1 year ago

Hi I want to make a pr on this issue, can I create more rooms now?

Himanshu2561 commented 1 year ago

Yeah sure @ShatilKhan

MaAnCoSa commented 1 year ago

Hi! This is my first time contributing to open source. Do I need to be assigned to the issue to start making a new dungeon? Or can I just start working on it and make a PR whenever?

P.S.: I fixed a typo and made the PR #235 . Hope it's alright.

Bambam320 commented 1 year ago

Hi, I would like to add floors and rooms to the time travel dungeon. Is that ok or is there something else I could work on?

anubhav1206 commented 1 year ago

Can I work on this?

donnaada commented 1 year ago

Collaborated with @ShadowDraco to create a mario inspired dungeon. Submitted a PR #245