Improve home page UI. - Githubissues

MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐

https://markdown-dungeon.netlify.app/

MIT License

322 stars 148 forks source link

Improve home page UI. #144

Closed xaerru closed 3 years ago

xaerru commented 3 years ago

Made the UI of the home page a little better.

xaerru commented 3 years ago

Site isn't responsive on Netlify, but when I run it locally it is.

xaerru commented 3 years ago

I don't know why this is happening but whenever I open it in mobile view it doesn't render correctly until I click on a card and then go back to the home page.

xaerru commented 3 years ago

It's changing after building. So it's not a Netlify problem

xaerru commented 3 years ago

I overthought it. It was really simple. I didn't even need react-device-detect.

ming-tsai commented 3 years ago

Hi @gauravsingh5, Thanks for contributions, could your replace double quotes to single? I should configure prettier

ming-tsai commented 3 years ago

Hi @gauravsingh5, Please ensure the card is the same size and the ArrowForward button should on the left side And keep 3 cards on one flow

xaerru commented 3 years ago

The size of the cards didn't match because the description of the Chinese dungeon was 3 characters less. I used google translate and added "and start" to the description but you can change it as i don't know Chinese. Just add 3 more characters to the description.

ming-tsai commented 3 years ago

The size of the cards didn't match because the description of the Chinese dungeon was 3 characters less. I used google translate and added "and start" to the description but you can change it as i don't know Chinese. Just add 3 more characters to the description.

Couldn't add the same size for the card o material ui?

xaerru commented 3 years ago

I don't know about material ui much but let me try.

ming-tsai commented 3 years ago

Could you tell me what do you want to change? Because for me the old card size is good, it doesn't seem too big or too small

xaerru commented 3 years ago

All the cards were located in center and the space on the side was looking weird.

ming-tsai commented 3 years ago

For me is good, I'm just think have a background image