MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
323 stars 148 forks source link

Added link to home page on rooms #164

Closed AkshatJindal1 closed 3 years ago

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

AkshatJindal1 commented 3 years ago

Issue link: https://github.com/MakeContributions/markdown-dungeon/issues/163

@ming-tsai please have a look

ming-tsai commented 3 years ago

Nice work @AkshatJindal1, But could you move the icon to the header as this example? image

AkshatJindal1 commented 3 years ago

@ming-tsai implemented the requested changes. Please verify

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉. You are invited to be part of the team, the invitation link