search

MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
323 stars 148 forks source link

chore(time-travel): added new floors and rooms #175

Closed Karguel1995 closed 3 years ago

Karguel1995 commented 3 years ago

Hello! It's my first pull request. Hope everything is fine, and you like it :)

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

Karguel1995 commented 3 years ago

Upload! @hkumar0132 , could you check?

hkumar0132 commented 3 years ago

Upload! @hkumar0132 , could you check?

Appreciate the efforts! It seems like you have made a merge commit.

@ming-tsai Is it okay to approve a 'merge commit'?

ming-tsai commented 3 years ago

Upload! @hkumar0132 , could you check?

Appreciate the efforts! It seems like you have made a merge commit.

@ming-tsai Is it okay to approve a 'merge commit'?

DO NOT merge the pull request, only approve it, thanks

hkumar0132 commented 3 years ago

Upload! @hkumar0132 , could you check?

Appreciate the efforts! It seems like you have made a merge commit. @ming-tsai Is it okay to approve a 'merge commit'?

DO NOT merge the pull request, only approve it, thanks

Great! Waiting for the changes from @Karguel1995

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! We here at MakeContributions are proud of you! 🎉🎉🎉🎉. You are invited to join the team on Github and Discord.