search

MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
323 stars 148 forks source link

chore: added floating button links #183

Closed ehteshaxm closed 2 years ago

ehteshaxm commented 3 years ago

Created a new Component HoverButton in the components folder and created floating button links in it

welcome[bot] commented 3 years ago

Thanks for opening this pull request! Please check out our contributing guidelines.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ming-tsai commented 3 years ago

Hi @cadmaus, Nice work, but try to use hover to show detail and the bug link should be this one https://github.com/MakeContributions/markdown-dungeon/issues/new

ehteshaxm commented 3 years ago

hover to show detail

I didn't get the hover to show detail part? Can you elaborate

ming-tsai commented 3 years ago

hover to show detail

I didn't get the hover to show detail part? Can you elaborate

Sorry @cadmaus, Now to show all buttons you need to click the floating button, I'm asking if you could change the event to onhover the floating then show all buttons

ming-tsai commented 3 years ago

Hi @cadmaus, Any updates?

ehteshaxm commented 3 years ago

Hi @cadmaus, Any updates?

Sorry, @ming-tsai I had my college exams, I will do it by tomorrow morning

ming-tsai commented 2 years ago

Hi @ehteshaxm, Any update?

ming-tsai commented 2 years ago

Hi @ehteshaxm, This pull request will be closed, any updated please re-open this one