MakeContributions / markdown-dungeon

This is an example that how to use Markdown creating a dungeon, please give a ⭐
https://markdown-dungeon.netlify.app/
MIT License
323 stars 148 forks source link

chore(normal-dungeon): Standardized spacing and restart game option #197

Closed gonuma closed 2 years ago

gonuma commented 2 years ago

Many of the options in English/Normal-Dungeon didn't include line breaks (contribution guideline #5) or trailing new lines, so I added those.

A few options also began with or emoji, so I changed to - and moved the emoji into the option text to match the style of other options.

Lastly, a few of the [Restart the game] options didn't follow the styling of the others, so I standardized those.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

gonuma commented 2 years ago

I apologize if this was too many files edited at once, but it was mostly just adding/removing spaces, and I thought it'd be better to do the whole story at once

ming-tsai commented 2 years ago

Hi @gonuma, Nice work, but please remove the new line between options. Example: Before

- [Option 1](./example1)

- [Option 2](./example2)

After

- [Option 1](./example1)
- [Option 2](./example2)
ming-tsai commented 2 years ago

Hi @gonuma, Any updated?

ming-tsai commented 2 years ago

Hi @gonuma, Any update please re-open this pull request