MakePrisms / bitcoinmints

List, review, and find bitcoin mints.
https://bitcoinmints.com
18 stars 5 forks source link

Ad-hoc star voting #22

Open elsirion opened 1 month ago

elsirion commented 1 month ago

When looking at the published recommendation events I noticed that the star voting system of bitcoinmints.com is implemented in a very ad-hoc way. Instead of adding another optional tag to contain the star voting or making the content JSON encoded you just serialize a [x/5] prefix in front of the comment. I think it would be good to standardize some sort of voting system into NIP-87 to ensure compatibility. cc @benthecarman

Example NIP-87 event presumably created by bitcoinmints.com

```json { "id": "f4c9a160e3cc3933e3669ea16bec3e6f3c0c699d1d1082ebf7f8052851579ace", "pubkey": "0ace5084321584fc67174b6ed498d2f033f4398a229e679785388bb4de5a460c", "created_at": 1720104015, "kind": 38000, "tags": [ [ "k", "38172" ], [ "u", "https://stablenut.umint.cash", "cashu" ], [ "a", "38172:cashu-mint-pubkey:zh5vikcpv3qiokij", "wss://relay.satoshidnc.com", "cashu" ], [ "d", "zh5vikcpv3qiokij" ] ], "content": "[5/5] I've used this mint one time for one transaction and it functioned. Thanks, stablenut mint!", "sig": "501b41f32fdb4bc3d5ed6484958f8af244df204cd53344b9c849f98cb7cc52ae4e901ac01b158fa62998dc3fc50439decd0d50b245555c0ebd7d989c586b95cd" }, ```

gudnuf commented 1 month ago

agreed, I tried to get some sort of "rating" tag into NIP-87, but everyone seemed to be against it. My reasoning for putting it in the content was so that clients that don't support the rating could still see it, but would be better to have as a tag.