MakeYourLifeEasier / novel-ebook.com

Bugtracker of novel-ebook.com
12 stars 0 forks source link

Ending Chapter Download Not Inclusive #178

Closed NightB1ade closed 3 years ago

NightB1ade commented 3 years ago

Describe the bug getChapters downloading does not include the ending chapter.

Subsequently one is not able to download the last chapter of any novel.

To Reproduce Steps to reproduce the behavior:

  1. Choose any novel
  2. Choose any starting chapter
  3. Choose any ending chapter
  4. Download
  5. Downloaded epub does not include ending chapter

Expected behavior Selected ending chapter is inclusive of the download, also the ability therefore to download the last chapter

Screenshots Capture

To rectify, I believe this should be i <= r (or other methods exist, this just being one suggestion)

Additional Information Had a search on issues in regards to last chapter, final chapter, ending chapter etc. Didn't spot anything in particular that was relevant, but would happily be corrected if there are.

NightB1ade commented 3 years ago

Come to think of it, this'll also end up with a blank epub if a single chapter is attempted to be downloaded

MichaelGuardian commented 3 years ago

Thanks for reporting this issue!

Yea something went wrong with yesterdays deploy and the code got overwritten by an old test version. i <= r is how it supposed to be. It should be fixed now.

NightB1ade commented 3 years ago

Confirmed it works ;) Ta muchly!