search

Makepad-fr / fbjs

Tooling that automates your Facebook interactions.
https://www.npmjs.com/package/@makepad/fbjs
GNU General Public License v3.0
64 stars 23 forks source link

Facebook login issue fix #14

Closed kaanyagci closed 3 years ago

kaanyagci commented 3 years ago

Added

Changed

Fixed

ameierchen commented 3 years ago

fix works for me except one little detail, i am not using english system settings/browser. Therefore i do not get over waiting for the Button containing "log In".

I changed lines 353 and 254 in index.js to

  await page.waitForXPath('//button[@data\-testid="royal_login_button"]')
  const [loginButton] = await page.$x('//button[@data\-testid="royal_login_button"]');

Now it works nicely

kaanyagci commented 3 years ago

fix works for me except one little detail, i am not using english system settings/browser. Therefore i do not get over waiting for the Button containing "log In".

I changed lines 353 and 254 in index.js to

  await page.waitForXPath('//button[@data\-testid="royal_login_button"]')
  const [loginButton] = await page.$x('//button[@data\-testid="royal_login_button"]');

Now it works nicely

Hi @ameierchen don't hesitate to commit your changes on this branch. We can see if we can include on this patch