New features!

[iMrDJAi]

What's new?
Added new fields to the Post interface:

export default interface Post {
  authorName: string,
  authorUrl: string | null,
  authorAvatar: string | null,
  date: string,
  permalink: string,
  id: string,
  contentText: string | null,
  contentHtml: string | null,
  images: any[]
}

Yup, I've added all of these. It been kinda tricky since I had to make it hover on the post link under the author name to grab the date.

What's missing?
Videos. I haven't add an implementation for them yet. Also I haven't update the example.

[kaanyagci]

@iMrDJAi looks good! I just changed the base branch from master to development. Do you mind fixing merge conflicts?

[iMrDJAi]

All conflicts are fixed!

[iMrDJAi]

@kaanyagci Shouldn't we gitignore tsconfig.tsbuildinfo?
Also I'm using node v14.17.2, and the library worked perfectly, probably you should double check this: https://github.com/Makepad-fr/fbjs/blob/d89e8367039c66a745008e1b2ada7cb0d24d6e47/example/README.md#L5

[kaanyagci]

@iMrDJAi actually we can .gitignore the tsconfig.tsbuildinfo build info file but the advantage of tracking this file is to decrease the compilation time by incremental compiling.

[kaanyagci]

For the README lines you're right. The written version is the version that I'm using on my computer, but if you node v14.17.2 works great, I'll update this. Do you mind share your npm version too?

[iMrDJAi]

@iMrDJAi actually we can .gitignore the tsconfig.tsbuildinfo build info file but the advantage of tracking this file is to decrease the compilation time by incremental compiling.

Roger that.

[iMrDJAi]

For the README lines you're right. The written version is the version that I'm using on my computer, but if you node v14.17.2 works great, I'll update this. Do you mind share your npm version too?

@kaanyagci Sure, my npm version is 6.14.13, but this doesn't change the fact that it may work on a lower version, technically you should target the min supported version of puppeteer (node v8.x should work fine, check this). In the other side I couldn't Install the dev dependencies with node v10 (I used to have this before upgrading to v14), so the min supported version for the development machine is higher than the min version for production.

[kaanyagci]

Got it ! Thanks I'll update the README ASAP.

[iMrDJAi]

Also don't forget to update the example:
https://github.com/Makepad-fr/fbjs/blob/d89e8367039c66a745008e1b2ada7cb0d24d6e47/example/groupName123

[kaanyagci]

There's still the email issue that you had the last time. I will fix this wile merging though. I've a meeting right know I'll do it just after that

[iMrDJAi]

There's still the email issue that you had the last time. I will fix this wile merging though. I've a meeting right know I'll do it just after that

@kaanyagci I found out that when I created the previous pull request from the web interface it included my email automatically with the associated commit since it wasn't set to private on my account settings.
Yeah there is nothing to do about that, any commit I've done on the web interface exposed my email, but anyway this one won't because I changed my account settings.