search

Maker-Management-Platform / agent

BSD 2-Clause "Simplified" License
16 stars 2 forks source link

fix: Fix logPath handling #86

Closed bjw-s closed 5 months ago

bjw-s commented 5 months ago

Currently, it's not possible to set an empty value for the LOG_PATH environment variable because the related Viper config setting is missing. Additionally, the stlib.log file isn't actually being written to logPath.

This PR fixes both, making it easier to run the container image with restricted permissions.

EduardoOliveira commented 5 months ago

Hi, sorry for the delay in the response. Could I ask you to pull request from the "latest" branch, I would like to release this as an hotfix and currently master already has features from a next release.

bjw-s commented 5 months ago

Sure thing 👍

bjw-s commented 5 months ago

I've rebased off upstream/latest and changed the PR base to latest as well. If there's anything else, let me know