search

Maker-Management-Platform / agent

BSD 2-Clause "Simplified" License
16 stars 2 forks source link

feat: Make dataPath configurable #87

Closed bjw-s closed 4 months ago

bjw-s commented 5 months ago

In addition to making the logPath configurable in my previous PR, this adds the ability to configure where the application stores its database/printer data.

EduardoOliveira commented 5 months ago

Hi there Thanks a lot for the pull requests, it really makes me happy to see people engaging with the project.

I've done some work on the settings/config side for the next release, but I haven't merged to master. I would kindly ask you if you could go over it as I think it already implements that feature, https://github.com/Maker-Management-Platform/agent/blob/refs/heads/62-implement-settings-endpoint/core/runtime/config.go

bjw-s commented 5 months ago

No worries :) Glad to contribute!

It looks like you indeed have some changes lined up to the configuration. The main thing my PR does is make the folder used here configurable. Because if you run the container as non-root, that data folder will not be writable. (I honestly haven't checked if there are any other folders under /app being written to at runtime).

EduardoOliveira commented 4 months ago

Once again, thank you for the pull request. I'll be closing it as most of the settings system was redone and implements what's being discussed here. As for the mount point permissions. I would love to get a configurable uid/guid working, similar to linuximages, I would love to have a discussion about that and if possible a contribution