MakersAsylumIndia / M19O2

M19O2 open source hardware Oxygen Concentrator based on the Pressure Swing Adsorption cycle aka Skarstorm cycle
MIT License
64 stars 13 forks source link

Prepare a comprehensive tool list #14

Closed bkamapantula closed 3 years ago

bkamapantula commented 3 years ago

For new labs, we need to identify a comprehensive tool list. Here's a preliminary draft:

https://docs.google.com/spreadsheets/d/1DynT9Mh8jcV9qHxwFuQxj1fcQQHj_v_ymwpoZD1L23g/edit#gid=1782181776

Note: this is posted here from the FAQs sheet post discussion on 2nd May.

Please identify an assignee.

nirmaljeffrey commented 3 years ago

Hey @bkamapantula, Should we need to add more tools apart from the ones in google sheet? if not, Can I raise a pull request with the tools list mentioned in the google sheet and its corresponding images as markdown file (readme)?

bkamapantula commented 3 years ago

hi @nirmaljeffrey! the list has been expanded since I created the issue. I'll check with the team tonight and share an update here in ~6 hrs

bkamapantula commented 3 years ago

hi @nirmaljeffrey, the current list is more of a guideline and not necessarily a comprehensive one. Sorry for the late response!

Please go ahead create a PR. We can periodically update it.

nirmaljeffrey commented 3 years ago

sure @bkamapantula will raise it by today. Can you also please mention the location where I should add this readme file in this repository?

bkamapantula commented 3 years ago

Thanks! Is it possible to add it in the Wiki? Not sure if it's version controlled though.

If it isn't, adding under docs directory should be good. @Anool if not, please suggest otherwise

nirmaljeffrey commented 3 years ago

https://docs.github.com/en/communities/documenting-your-project-with-wikis/viewing-a-wikis-history-of-changes - github wiki is version controlled. It will be the correct place for adding all these docs that we have in google sheets. @bkamapantula I'm unable to create a wiki. So can you please create a wiki for this repo? , so that I can clone and raise a PR for tools list.

bkamapantula commented 3 years ago

done https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

nirmaljeffrey commented 3 years ago

nirmaljeffrey (nirmal/#14-add-lab-tools-list) M19_OxiKit.wiki $ git push --set-upstream origin nirmal/#14-add-lab-tools-list remote: Permission to MakersAsylumIndia/M19_OxiKit.wiki.git denied to nirmaljeffrey. fatal: unable to access 'https://github.com/MakersAsylumIndia/M19_OxiKit.wiki.git/': The requested URL returned error: 403

@bkamapantula, I'm unable push my branch to remote. please check. It looks like i dont have permission.

nirmaljeffrey commented 3 years ago

@bkamapantula, If I don't have the access to the repo, should I need to fork this repo and raise PR?

bkamapantula commented 3 years ago

I think it's a permission issue, I can't add you as a developer (I don't have access).

can you please fork and raise a PR?

nirmaljeffrey commented 3 years ago

I tried to fork the main repo, but github wiki is treated as seperate repo. So I'm unable to fork the github wiki. A new wiki was created for my forked repository. I have attached the screenshot for the wiki in my forked repository. Screenshot 2021-05-06 at 2 59 36 PM

bkamapantula commented 3 years ago

i see, please create it in your repo and share the link here, I'll create. for subsequent edits we can use this issue thread.

nirmaljeffrey commented 3 years ago

I will share the updated markdown file. please add the file to the remote repo. whenever an edit is requested, I will share the updated markdown in this issue thread. is that fine for you @bkamapantula

nirmaljeffrey commented 3 years ago

Lab-tools-list.md

bkamapantula commented 3 years ago

looks good, thanks @nirmaljeffrey!

nirmaljeffrey commented 3 years ago

@bkamapantula in this markdown file, I just copied the items from google sheets. But I didn't do any changes as of now. If I add images, will there any copyright issues? and also If i add links to amazon or flipkart or other online sellers, will there be any problem? Am I allowed to add images and add links?

bkamapantula commented 3 years ago

images and links are fine, no problem.

nirmaljeffrey commented 3 years ago

Also, it would be great if developer access are given to all and merge access for master branch can be restricted to maintainers. So that everyone can raise PRs. Atleast this will be a problem for people who wants to contribute for wiki.

bkamapantula commented 3 years ago

agreed, @Anool -- please review on the dev access when you get a chance.

Wiki is live: https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

thanks much @nirmaljeffrey!

nirmaljeffrey commented 3 years ago

@bkamapantula, Glad to help. Ping me if anything is required in git. will spend my free time to contribute to this project.

Hemant-Git911 commented 3 years ago

How to get involved in M19 Initiavite as a FY student Mechanical @makersasylum

bkamapantula commented 3 years ago

closing this issue as the tool list is live on Wiki.

bkamapantula commented 3 years ago

How to get involved in M19 Initiavite as a FY student Mechanical @makersasylum

hi @Hemant-Git911, please register your interest with us:

once your details are in, we will reach out on how to get involved. thanks!

Anool commented 3 years ago

agreed, @Anool -- please review on the dev access when you get a chance.

Wiki is live: https://github.com/MakersAsylumIndia/M19_OxiKit/wiki/Lab-tools-list

thanks much @nirmaljeffrey!

Can I add you folks as "maintainer", or will you need higher access levels?

nirmaljeffrey commented 3 years ago

@Anool, it's not required. The problem is with wikis. Either edit access should be given to everyone or restricted only to maintainers. So I will use this workaround for raising PR for wikis - https://www.growingwiththeweb.com/2016/07/enabling-pull-requests-on-github-wikis.html

bkamapantula commented 3 years ago

yes

for non-wiki contributions, contributors can use the fork + PR approach.

for the Wiki contributions, we could do that or (if it looks complicated to set up) use the Issues + discussion + maintainers adding to this repo.