Makespace / members-app

Simplifying operations for Cambridge MakeSpace
MIT License
1 stars 1 forks source link

Use html templating library to protect from injection #39

Open Lan2u opened 4 days ago

Lan2u commented 4 days ago

https://github.com/Makespace/members-app/issues/35

Also provides the member number and member email handlebar helpers to be used for https://github.com/Makespace/members-app/issues/36 and https://github.com/Makespace/members-app/issues/38

The transition between handlebars -> typescript (for example when calling a decorator) isn't statically typechecked. I don't think this is a big enough issue to override the utility handlebars provides (particularly around injection safety) but might be worth seeing if we can improve.

This is the first time I've used handlebars and from writing this conversion it seems a really nice library for what we need.