search

MakhouT / treehouseDownloader

Download video's from teamtreehouse.com if you have a subscription and don't want to use the build-in iTunes downloader
33 stars 4 forks source link

Please make instruction more clear (README.MD) #1

Closed 1c7 closed 8 years ago

1c7 commented 8 years ago

For example

  1. git clone ...
  2. cd ...
  3. node install
  4. node app.js something like that . list all command
1c7 commented 8 years ago

image great work, btw. image

1c7 commented 8 years ago

but webpage not showing percentage is little bit annoying. maybe you can improve that? image and I am not sure the webpage are still downloading or fail or stop...

1c7 commented 8 years ago

after refresh, it work now image

1c7 commented 8 years ago

it stop downloading again image probably there are to much file or file too big. I am not sure. a simple solution is just list all download link. Let user right click then "Save as" I fork your code into my computer, and I am trying to modify your code make it just list all download link.

MakhouT commented 8 years ago

Hi thanks for your feedback. I'll work on it. But even if the progress icon has stopped loading, it's still downloading, it's just taking a bit of time. The progress bar is still work in progress and will be added later. Don't forget it's being downloaded with nodejs, so it's asynchronous - it's possible that the second video has been finished before the first one. Just be a bit patient and it will be finished :) So don't kill the server example

MakhouT commented 8 years ago

Oh yeah if you want to have it download quicker, you can download the SD version, at the moment it's hardcoded to download HD just remove + "&hd=yes" in download.js on line 26, then it should download the SD version which is smaller in video size.

1c7 commented 8 years ago

understand, thank you

1c7 commented 8 years ago

like you said, it really working, even the icon not moving.

image image

so I am not gonna change your code to make it list all download link. I fork and only change README.md. make it more clear. I send a pull request later. maybe you can merge that and then make it better.

English is not my native language. so if my English sentences are wrong, please point it out. Thank you

1c7 commented 8 years ago

Few question:

  1. If I downloading "Mobile Game Design" and then download "Logo Design Basic" the second download will cancel the first one or not?
  2. If I download "Mobile Game Design" Again, because download speed too slow. program will skip course that already been downloaded, or just download all course again, then overwrite existing file?
MakhouT commented 8 years ago

Thanks for the pull request, Your readme is indeed a bit better. I'll merge it down to the project.

To answer your questions:

  1. I don't know, I did not explicitly programmed that but as nodejs is async, it should just continue I think, but I'll double check and I will get back to you on this.
  2. I think it will download it again, but again not sure on this one. I will double check too and will get back to you.

Upcoming features:

  1. A check box to download HD or not
  2. Progress bar
MakhouT commented 8 years ago

With the pull requested merged, I will be closing this issue now.

1c7 commented 8 years ago

:D