fix precompile by removing src attr from plot constructor

MakieOrg / GeoMakie.jl

Geographical plotting utilities for Makie.jl

https://geo.makie.org

MIT License

161 stars 23 forks source link

fix precompile by removing src attr from plot constructor #245

Open SimonDanisch opened 2 weeks ago

asinghvi17 commented 2 weeks ago

Will test this locally then merge.

asinghvi17 commented 2 weeks ago

It looks like this doesn't address plot (as opposed to plot!, which works beautifully).

I guess you can't dispatch on create_plot, since it wouldn't have any arguments to dispatch on. Maybe we could refactor create_plot to create the Axis and then call create_plot!?

SimonDanisch commented 2 weeks ago

You can't currently do plot(...) to get a geo axis, can you?

asinghvi17 commented 2 weeks ago

plot(...; axis = (; type = GeoAxis, ...)) works (on master with the eval hack) and is shown in the docs. You may not want to set source in the axis settings because that sets the source CRS for every subsequent plot.