search

MakieOrg / GeoMakie.jl

Geographical plotting utilities for Makie.jl
https://geo.makie.org
MIT License
170 stars 25 forks source link

Released versions don't work on Julia 1.6 #72

Closed niclasmattsson closed 3 years ago

niclasmattsson commented 3 years ago

My packages that use GeoMakie get various strange errors when running in Julia 1.6, so I went back to basics and decided to try to get the simplest README example working in a new environment. Here's a log of the package installation. Notice when adding Makie that GeoMakie immediately downgrades to v0.1.14 and AbstractPlotting to v0.11.2.

julia> cd("MakieTest")

(@v1.6) pkg> activate .
  Activating new environment at `C:\Stuff\Julia\MakieTest\Project.toml`

(MakieTest) pkg> add GeoMakie
    Updating registry at `C:\Users\niclas\.julia\registries\General`
    Updating git-repo `https://github.com/JuliaRegistries/General.git`
   Resolving package versions...
    Updating `C:\Stuff\Julia\MakieTest\Project.toml`
  [db073c08] + GeoMakie v0.1.15
    Updating `C:\Stuff\Julia\MakieTest\Manifest.toml`
  [621f4979] + AbstractFFTs v1.0.1
  [537997a7] + AbstractPlotting v0.13.11
  [79e6a3ab] + Adapt v3.3.0
  [27a7e980] + Animations v0.4.1
  [4fba245c] + ArrayInterface v3.1.7
  [13072b0f] + AxisAlgorithms v1.0.0
  [fa961155] + CEnum v0.4.1
  [d360d2e6] + ChainRulesCore v0.9.38
  [a2cac450] + ColorBrewer v0.4.0
  [35d6a980] + ColorSchemes v3.12.0
  [3da002f7] + ColorTypes v0.10.12
  [c3611d14] + ColorVectorSpace v0.8.7
  [5ae59095] + Colors v0.12.7
  [34da2185] + Compat v3.27.0
  [d38c429a] + Contour v0.5.7
  [9a962f9c] + DataAPI v1.6.0
  [864edb3b] + DataStructures v0.18.9
  [e2d170a0] + DataValueInterfaces v1.0.0
  [31c24e10] + Distributions v0.24.18
  [ffbed154] + DocStringExtensions v0.8.4
  [5160dea5] + EarCut v2.0.0
  [da5c29d0] + EllipsisNotation v1.1.0
  [c87230d0] + FFMPEG v0.4.0
  [7a1cc6ca] + FFTW v1.4.0
  [5789e2e9] + FileIO v1.7.0
  [1a297f60] + FillArrays v0.11.7
  [53c48c17] + FixedPointNumbers v0.8.4
  [59287772] + Formatting v0.4.2
  [b38be410] + FreeType v3.0.1
  [663a7486] + FreeTypeAbstraction v0.8.4
  [cf35fbd7] + GeoInterface v0.5.5
  [61d90e0f] + GeoJSON v0.5.1
  [db073c08] + GeoMakie v0.1.15
  [5c1252a2] + GeometryBasics v0.3.10
  [c27321d9] + Glob v1.3.0
  [a2bd30eb] + Graphics v1.1.0
  [3955a311] + GridLayoutBase v0.4.1
  [42e2da0e] + Grisu v1.0.0
  [615f187c] + IfElse v0.1.0
  [a09fc81d] + ImageCore v0.8.22
  [82e4d734] + ImageIO v0.3.1
  [6218d12a] + ImageMagick v1.2.1
  [9b13fd28] + IndirectArrays v0.5.1
  [a98d9a8b] + Interpolations v0.13.2
  [8197267c] + IntervalSets v0.5.3
  [f1662d9f] + Isoband v0.1.1
  [c8e1da08] + IterTools v1.3.0
  [82899510] + IteratorInterfaceExtensions v1.0.0
  [692b3bcd] + JLLWrappers v1.3.0
  [682c06a0] + JSON v0.21.1
  [0f8b85d8] + JSON3 v1.8.1
  [5ab0869b] + KernelDensity v0.6.2
  [2ab3a3ac] + LogExpFunctions v0.2.2
  [dbb5928d] + MappedArrays v0.4.0
  [7eb4fadd] + Match v1.1.0
  [e1d29d7a] + Missings v0.4.5
  [e94cdb99] + MosaicViews v0.3.3
  [9526e54e] + NASAEarthObservations v0.1.0
  [77ba4419] + NaNMath v0.3.5
  [510215fc] + Observables v0.3.3
  [6fe1bfb0] + OffsetArrays v1.6.2
  [bac558e1] + OrderedCollections v1.4.0
  [90014a1f] + PDMats v0.11.0
  [f57f5aa1] + PNGFiles v0.3.7
  [19eb6ba3] + Packing v0.4.1
  [5432bcbf] + PaddedViews v0.5.8
  [69de0a69] + Parsers v1.1.0
  [995b91a9] + PlotUtils v1.0.10
  [647866c9] + PolygonOps v0.1.1
  [21216c6a] + Preferences v1.2.1
  [9a7e659c] + Proj4 v0.7.4
  [1fd47b50] + QuadGK v2.4.1
  [c84ed2f1] + Ratios v0.4.0
  [3cdcf5f2] + RecipesBase v1.1.1
  [189a3867] + Reexport v0.2.0
  [ae029012] + Requires v1.1.3
  [79098fc4] + Rmath v0.7.0
  [992d4aef] + Showoff v0.3.2
  [73760f76] + SignedDistanceFields v0.4.0
  [a2af1166] + SortingAlgorithms v0.3.1
  [276daf66] + SpecialFunctions v1.3.0
  [cae243ae] + StackViews v0.1.1
  [aedffcd0] + Static v0.2.4
  [90137ffa] + StaticArrays v1.1.1
  [2913bbd2] + StatsBase v0.33.5
  [4c63d2b9] + StatsFuns v0.9.8
  [09ab397b] + StructArrays v0.4.2
  [856f2bd8] + StructTypes v1.7.2
  [3783bdb8] + TableTraits v1.0.1
  [bd369af6] + Tables v1.4.2
  [1cfade01] + UnicodeFun v0.4.1
  [efce3f68] + WoodburyMatrices v0.5.3
  [6e34b625] + Bzip2_jll v1.0.6+5
  [5ae413db] + EarCut_jll v2.1.5+1
  [b22a6f82] + FFMPEG_jll v4.3.1+4
  [f5851436] + FFTW_jll v3.3.9+7
  [d7e528f0] + FreeType2_jll v2.10.1+5
  [559328eb] + FriBidi_jll v1.0.5+6
  [c73af94c] + ImageMagick_jll v6.9.10-12+3
  [1d5cc7b8] + IntelOpenMP_jll v2018.0.3+2
  [aacddb02] + JpegTurbo_jll v2.0.1+3
  [c1c5ebd0] + LAME_jll v3.100.0+3
  [dd192d2f] + LibVPX_jll v1.9.0+1
  [89763e89] + Libtiff_jll v4.1.0+2
  [856f044c] + MKL_jll v2021.1.1+1
  [e7412a2a] + Ogg_jll v1.3.4+2
  [458c3c95] + OpenSSL_jll v1.1.1+6
  [efe28fd5] + OpenSpecFun_jll v0.5.3+4
  [91d4177d] + Opus_jll v1.3.1+3
  [58948b4f] + PROJ_jll v700.202.100+0
  [f50d1b31] + Rmath_jll v0.3.0+0
  [76ed43ae] + SQLite_jll v3.34.0+0
  [3161d3a3] + Zstd_jll v1.4.8+0
  [9a68df92] + isoband_jll v0.2.2+0
  [0ac62f75] + libass_jll v0.14.0+4
  [f638f0a6] + libfdk_aac_jll v0.1.6+4
  [b53b4c65] + libpng_jll v1.6.37+6
  [f27f6e37] + libvorbis_jll v1.3.6+6
  [1270edf5] + x264_jll v2020.7.14+2
  [dfaa095f] + x265_jll v3.0.0+3
  [0dad84c5] + ArgTools
  [56f22d72] + Artifacts
  [2a0f44e3] + Base64
  [ade2ca70] + Dates
  [8bb1440f] + DelimitedFiles
  [8ba89e20] + Distributed
  [f43a241f] + Downloads
  [b77e0a4c] + InteractiveUtils
  [4af54fe1] + LazyArtifacts
  [b27032c2] + LibCURL
  [76f85450] + LibGit2
  [8f399da3] + Libdl
  [37e2e46d] + LinearAlgebra
  [56ddb016] + Logging
  [d6f4376e] + Markdown
  [a63ad114] + Mmap
  [ca575930] + NetworkOptions
  [44cfe95a] + Pkg
  [de0858da] + Printf
  [3fa0cd96] + REPL
  [9a3f8284] + Random
  [ea8e919c] + SHA
  [9e88b42a] + Serialization
  [1a1011a3] + SharedArrays
  [6462fe0b] + Sockets
  [2f01184e] + SparseArrays
  [10745b16] + Statistics
  [4607b0f0] + SuiteSparse
  [fa267f1f] + TOML
  [a4e569a6] + Tar
  [8dfed614] + Test
  [cf7118a7] + UUIDs
  [4ec0a83e] + Unicode
  [e66e0078] + CompilerSupportLibraries_jll
  [deac9b47] + LibCURL_jll
  [29816b5a] + LibSSH2_jll
  [c8ffd9c3] + MbedTLS_jll
  [14a3606d] + MozillaCACerts_jll
  [83775a58] + Zlib_jll
  [8e850ede] + nghttp2_jll
  [3f19e933] + p7zip_jll
  Progress [========================================>]  3/3
3 dependencies successfully precompiled in 43 seconds (121 already precompiled)

(MakieTest) pkg> add Makie
   Resolving package versions...
    Updating `C:\Stuff\Julia\MakieTest\Project.toml`
  [db073c08] ↓ GeoMakie v0.1.15 ⇒ v0.1.14
  [ee78f7c6] + Makie v0.11.0
    Updating `C:\Stuff\Julia\MakieTest\Manifest.toml`
  [537997a7] ↓ AbstractPlotting v0.13.11 ⇒ v0.11.2
  [4fba245c] ↓ ArrayInterface v3.1.7 ⇒ v2.14.17
  [49dc2e85] + Calculus v0.5.1
  [d360d2e6] - ChainRulesCore v0.9.38
  [bbf7d656] + CommonSubexpressions v0.3.0
  [01453d9d] + DiffEqDiffTools v1.7.0
  [163ba53b] + DiffResults v1.0.3
  [b552c78f] + DiffRules v1.0.2
  [b4f34e82] + Distances v0.10.2
  [31c24e10] ↓ Distributions v0.24.18 ⇒ v0.23.8
  [da5c29d0] ↓ EllipsisNotation v1.1.0 ⇒ v1.0.0
  [c87230d0] ↓ FFMPEG v0.4.0 ⇒ v0.3.0
  [1a297f60] ↓ FillArrays v0.11.7 ⇒ v0.8.14
  [f6369f11] + ForwardDiff v0.10.18
  [f7f18e0c] + GLFW v3.4.1
  [38e38edf] + GLM v1.4.1
  [e9467ef8] + GLMakie v0.1.5
  [db073c08] ↓ GeoMakie v0.1.15 ⇒ v0.1.14
  [5c1252a2] ↓ GeometryBasics v0.3.10 ⇒ v0.2.15
  [3955a311] ↓ GridLayoutBase v0.4.1 ⇒ v0.3.7
  [615f187c] - IfElse v0.1.0
  [82e4d734] ↓ ImageIO v0.3.1 ⇒ v0.2.0
  [a98d9a8b] ↓ Interpolations v0.13.2 ⇒ v0.12.10
  [f1662d9f] - Isoband v0.1.1
  [5ab0869b] ↓ KernelDensity v0.6.2 ⇒ v0.5.1
  [d3d80556] + LineSearches v7.1.1
  [4345ca2d] + Loess v0.5.3
  [1914dd2f] + MacroTools v0.5.6
  [ee78f7c6] + Makie v0.11.0
  [5a521ce4] + MakieLayout v0.9.10
  [7269a6da] + MeshIO v0.4.0
  [66fc600b] + ModernGL v1.1.2
  [d41bc354] + NLSolversBase v7.5.0
  [429524aa] + Optim v0.22.0
  [90014a1f] ↓ PDMats v0.11.0 ⇒ v0.10.1
  [f57f5aa1] ↓ PNGFiles v0.3.7 ⇒ v0.2.1
  [d96e819e] + Parameters v0.12.2
  [647866c9] - PolygonOps v0.1.1
  [85a6dd25] + PositiveFactorizations v0.2.4
  [9a7e659c] ↓ Proj4 v0.7.4 ⇒ v0.7.3
  [65257c39] + ShaderAbstractions v0.2.5
  [1277b4bf] + ShiftedArrays v1.0.0
  [276daf66] ↓ SpecialFunctions v1.3.0 ⇒ v0.10.3
  [aedffcd0] - Static v0.2.4
  [90137ffa] ↓ StaticArrays v1.1.1 ⇒ v0.12.5
  [65254759] + StatsMakie v0.2.3
  [3eaba693] + StatsModels v0.6.22
  [3a884ed6] + UnPack v1.0.2
  [0656b61e] + GLFW_jll v3.3.3+0
  [d4300ac3] + Libgcrypt_jll v1.8.5+4
  [7e76a0d4] + Libglvnd_jll v1.3.0+3
  [7add5ba3] + Libgpg_error_jll v1.36.0+3
  [94ce4f54] + Libiconv_jll v1.16.0+7
  [58948b4f] ↓ PROJ_jll v700.202.100+0 ⇒ v7.2.1+0
  [02c8fc9c] + XML2_jll v2.9.11+0
  [aed1982a] + XSLT_jll v1.1.33+4
  [4f6342f7] + Xorg_libX11_jll v1.6.9+4
  [0c0b7dd1] + Xorg_libXau_jll v1.0.9+4
  [935fb764] + Xorg_libXcursor_jll v1.2.0+4
  [a3789734] + Xorg_libXdmcp_jll v1.1.3+4
  [1082639a] + Xorg_libXext_jll v1.3.4+4
  [d091e8ba] + Xorg_libXfixes_jll v5.0.3+4
  [a51aa0fd] + Xorg_libXi_jll v1.7.10+4
  [d1454406] + Xorg_libXinerama_jll v1.1.4+4
  [ec84b674] + Xorg_libXrandr_jll v1.5.2+4
  [ea2f1a96] + Xorg_libXrender_jll v0.9.10+4
  [14d82f49] + Xorg_libpthread_stubs_jll v0.1.0+3
  [c7cfdc94] + Xorg_libxcb_jll v1.13.0+3
  [c5fb5394] + Xorg_xtrans_jll v1.4.0+3
  [9a68df92] - isoband_jll v0.2.2+0
  Progress [========================================>]  7/7
7 dependencies successfully precompiled in 24 seconds (157 already precompiled)

Now trying the README example (for v0.1.14). 

julia> using GeoMakie, Makie
┌ Warning: MakieLayout.jl has been absorbed by AbstractPlotting.jl and will not receive any more updates.
│ It is enough to install AbstractPlotting to receive the newest functionality.
│ Visit the Makie docs at http://makie.juliaplots.org/ for more information on how to use it.
└ @ MakieLayout C:\Users\niclas\.julia\packages\MakieLayout\qJ2me\src\MakieLayout.jl:27

julia> lons = LinRange(-179.5, 179.5, 360);  # suppressing output, no problem here
lats = LinRange(-89.5, 89.5, 180);

field = [exp(cosd(l)) + 3(y/90) for l in lons, y in lats];

source = LonLat();
dest = WinkelTripel();

xs, ys = xygrid(lons, lats);
Proj4.transform!(source, dest, vec(xs), vec(ys));

julia> scene = surface(xs, ys; color = field, shading = false, show_axis = false, scale_plot = false)
Error showing value of type Scene:
ERROR: MethodError: no method matching shadertype(::FileIO.File{FileIO.DataFormat{:UNKNOWN}, String})
Closest candidates are:
  shadertype(::GLMakie.GLAbstraction.Shader) at C:\Users\niclas\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:63
  shadertype(::FileIO.File{FileIO.DataFormat{:GLSLShader}, Name} where Name) at C:\Users\niclas\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:64
  shadertype(::AbstractString) at C:\Users\niclas\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:67
Stacktrace:
  [1] compile_shader(path::String, source_str::String)
    @ GLMakie.GLAbstraction ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:145
  [2] (::GLMakie.GLAbstraction.var"#52#53"{String, Dict{String, String}, Dict{Symbol, Any}})()
    @ GLMakie.GLAbstraction ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:170
  [3] get!(default::GLMakie.GLAbstraction.var"#52#53"{String, Dict{String, String}, Dict{Symbol, Any}}, h::Dict{String, Vector{String}}, key::String)
    @ Base .\dict.jl:465
  [4] get_template!(path::String, view::Dict{String, String}, attributes::Dict{Symbol, Any})
    @ GLMakie.GLAbstraction ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:162
  [5] gl_convert(lazyshader::GLMakie.GLAbstraction.LazyShader, data::Dict{Symbol, Any})
    @ GLMakie.GLAbstraction ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLShader.jl:250
  [6] GLMakie.GLAbstraction.RenderObject(data::Dict{Symbol, Any}, program::GLMakie.GLAbstraction.LazyShader, pre::GLMakie.PostprocessPrerender, post::Nothing, bbs::Observable{GeometryBasics.HyperRectangle{3, Float32}}, main::Nothing)
    @ GLMakie.GLAbstraction ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLTypes.jl:327
  [7] RenderObject
    @ ~\.julia\packages\GLMakie\wpJsD\src\GLAbstraction\GLTypes.jl:295 [inlined]
  [8] postprocess(color::GLMakie.GLAbstraction.Texture{RGBA{FixedPointNumbers.N0f8}, 2}, position::GLMakie.GLAbstraction.Texture{Vec{4, Float32}, 2}, normal::GLMakie.GLAbstraction.Texture{Vec{3, Float32}, 2}, ssao_noise::GLMakie.GLAbstraction.Texture{Vec{2, Float32}, 2}, occlusion::GLMakie.GLAbstraction.Texture{Float32, 2}, objectid::GLMakie.GLAbstraction.Texture{Vec2{UInt16}, 2}, color_luma::GLMakie.GLAbstraction.Texture{RGBA{FixedPointNumbers.N0f8}, 2}, framebuffer_size::Observable{Tuple{Int64, Int64}})
    @ GLMakie ~\.julia\packages\GLMakie\wpJsD\src\glwindow.jl:92
  [9] GLMakie.GLFramebuffer(fb_size::Tuple{Int64, Int64})
    @ GLMakie ~\.julia\packages\GLMakie\wpJsD\src\glwindow.jl:203
 [10] GLMakie.Screen(; resolution::Tuple{Int64, Int64}, visible::Bool, title::String, kw_args::Base.Iterators.Pairs{Union{}, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ GLMakie ~\.julia\packages\GLMakie\wpJsD\src\screen.jl:316
 [11] Screen
    @ ~\.julia\packages\GLMakie\wpJsD\src\screen.jl:275 [inlined]
 [12] global_gl_screen
    @ ~\.julia\packages\GLMakie\wpJsD\src\screen.jl:346 [inlined]
 [13] global_gl_screen(resolution::Tuple{Int64, Int64}, visibility::Bool, tries::Int64)
    @ GLMakie ~\.julia\packages\GLMakie\wpJsD\src\screen.jl:356
 [14] global_gl_screen
    @ ~\.julia\packages\GLMakie\wpJsD\src\screen.jl:355 [inlined]
 [15] backend_display
    @ ~\.julia\packages\GLMakie\wpJsD\src\gl_backend.jl:57 [inlined]
 [16] display(d::AbstractPlotting.PlotDisplay, scene::Scene)
    @ AbstractPlotting ~\.julia\packages\AbstractPlotting\q9DyS\src\display.jl:45
 [17] display(x::Any)
    @ Base.Multimedia .\multimedia.jl:328
 [18] #invokelatest#2
    @ .\essentials.jl:708 [inlined]
 [19] invokelatest
    @ .\essentials.jl:706 [inlined]
 [20] print_response(errio::IO, response::Any, show_value::Bool, have_color::Bool, specialdisplay::Union{Nothing, AbstractDisplay})
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:247
 [21] (::REPL.var"#40#41"{REPL.LineEditREPL, Pair{Any, Bool}, Bool, Bool})(io::Any)
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:231
 [22] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:462
 [23] print_response(repl::REPL.AbstractREPL, response::Any, show_value::Bool, have_color::Bool)
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:229
 [24] (::REPL.var"#do_respond#61"{Bool, Bool, REPL.var"#72#82"{REPL.LineEditREPL, REPL.REPLHistoryProvider}, REPL.LineEditREPL, REPL.LineEdit.Prompt})(s::REPL.LineEdit.MIState, buf::Any, ok::Bool)
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:798
 [25] #invokelatest#2
    @ .\essentials.jl:708 [inlined]
 [26] invokelatest
    @ .\essentials.jl:706 [inlined]
 [27] run_interface(terminal::REPL.Terminals.TextTerminal, m::REPL.LineEdit.ModalInterface, s::REPL.LineEdit.MIState)
    @ REPL.LineEdit C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\LineEdit.jl:2441
 [28] run_frontend(repl::REPL.LineEditREPL, backend::REPL.REPLBackendRef)
    @ REPL C:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.6\REPL\src\REPL.jl:1126
 [29] (::REPL.var"#44#49"{REPL.LineEditREPL, REPL.REPLBackendRef})()
    @ REPL .\task.jl:406

I can see from the commits that you're in the midst of "starting anew", but could you please first consider releasing a version of the established API that works in Julia 1.6?

niclasmattsson commented 3 years ago

After some more digging I think I found the problem. It was an incompatibility between GLMakie and the latest versions of FileIO, see https://github.com/JuliaPlots/Makie.jl/issues/863. GeoMakie had constraints on GLMakie versions so it wouldn't accept the bugfix, but as a temporary workaround explicitly downgrading to FileIO v1.5.1 fixed the issues I was having.

So to update this issue: would you consider updating GeoMakie v0.1.15 so it works with the latest releases of Makie and GLMakie? I think that would be the cleanest fix.

SimonDanisch commented 3 years ago

Oh, I actually never released the new version.

but could you please first consider releasing a version of the established API that works in Julia 1.6?

I don't think it's possible to have the old GeoMakie code work with the latest release of GLMakie... Did you really get the old version to work with the newest GLMakie? Anyways, I don't have much time for this Package, so I can at most maintain the newest code... I can try to release that today!

niclasmattsson commented 3 years ago

Did you really get the old version to work with the newest GLMakie?

No, sorry if I wasn't clear. I left it constrained by GeoMakie, it ended up at v0.1.5 I think. I assumed you had lots more work left with the new version, but releasing that works for me. Then I can just adapt to the new API to get updated versions of the dependencies.

niclasmattsson commented 3 years ago

I tried updating to master instead, but unfortunately that seems broken too. When I try the new README example on master I get an empty Makie window (or rather empty except for axes) and this error:

Error in callback:
MethodError: no method matching inverse_transform(::AbstractPlotting.PointTrans{2, WARNING: both GridLayoutBase and AbstractPlotting export "bottom"; uses of it in module GeoMakie must be qualified
WARNING: both MakieLayout and GeometryBasics export "height"; uses of it in module GeoMakie must be qualified
WARNING: both GridLayoutBase and AbstractPlotting export "left"; uses of it in module GeoMakie must be qualified
WARNING: both GridLayoutBase and AbstractPlotting export "right"; uses of it in module GeoMakie must be qualified
WARNING: both GridLayoutBase and AbstractPlotting export "top"; uses of it in module GeoMakie must be qualified
WARNING: both MakieLayout and GeometryBasics export "width"; uses of it in module GeoMakie must be qualified
GeoMakie.PROJ{Projection, Projection}})
Closest candidates are:
  inverse_transform(::typeof(identity)) at C:\Users\niclas\.julia\packages\AbstractPlotting\M8Nlv\src\layouting\transformation.jl:316
  inverse_transform(::typeof(log10)) at C:\Users\niclas\.julia\packages\AbstractPlotting\M8Nlv\src\layouting\transformation.jl:317
  inverse_transform(::typeof(log)) at C:\Users\niclas\.julia\packages\AbstractPlotting\M8Nlv\src\layouting\transformation.jl:318
  ...
Stacktrace:
  [1] process_interaction(r::AbstractPlotting.MakieLayout.RectangleZoom, event::MouseEvent, ax::Axis)
    @ AbstractPlotting.MakieLayout ~\.julia\packages\AbstractPlotting\M8Nlv\src\makielayout\interactions.jl:147
  [2] (::AbstractPlotting.MakieLayout.var"#process_event#262"{Axis})(event::MouseEvent)
    @ AbstractPlotting.MakieLayout ~\.julia\packages\AbstractPlotting\M8Nlv\src\makielayout\layoutables\axis.jl:392
  [3] #invokelatest#2
    @ .\essentials.jl:708 [inlined]
  [4] invokelatest
    @ .\essentials.jl:706 [inlined]
  [5] notify
    @ ~\.julia\packages\Observables\OFj0u\src\Observables.jl:88 [inlined]
  [6] setindex!
    @ ~\.julia\packages\Observables\OFj0u\src\Observables.jl:248 [inlined]
  [7] (::AbstractPlotting.MakieLayout.var"#70#73"{Scene, Base.RefValue{Float64}, Base.RefValue{Bool}, Base.RefValue{Bool}, Base.RefValue{Union{Nothing, AbstractPlotting.Mouse.Button}}, Base.RefValue{Bool}, Base.RefValue{GeometryBasics.Point{2, Float32}}, Base.RefValue{GeometryBasics.Point{2, Float32}}, Base.RefValue{AbstractPlotting.Mouse.DragEnum}, AbstractPlotting.MakieLayout.var"#is_mouse_over_relevant_area#72"{Scene, Tuple{}}, Observable{MouseEvent}, Module})(mp::Tuple{Float64, Float64})
    @ AbstractPlotting.MakieLayout ~\.julia\packages\AbstractPlotting\M8Nlv\src\makielayout\mousestatemachine.jl:190
  [8] #invokelatest#2
    @ .\essentials.jl:708 [inlined]
  [9] invokelatest
    @ .\essentials.jl:706 [inlined]
 [10] notify
    @ ~\.julia\packages\Observables\OFj0u\src\Observables.jl:88 [inlined]
 [11] setindex!
    @ ~\.julia\packages\Observables\OFj0u\src\Observables.jl:248 [inlined]
 [12] (::GLMakie.var"#67#68"{Events, GLFW.Window})(#unused#::Nothing)
    @ GLMakie ~\.julia\packages\GLMakie\WcG7U\src\events.jl:4
 [13] #invokelatest#2
    @ .\essentials.jl:708 [inlined]
 [14] invokelatest
    @ .\essentials.jl:706 [inlined]
 [15] notify
    @ ~\.julia\packages\Observables\OFj0u\src\Observables.jl:88 [inlined]
 [16] setindex!(observable::Observable{Nothing}, val::Nothing)
    @ Observables ~\.julia\packages\Observables\OFj0u\src\Observables.jl:248
 [17] fps_renderloop(screen::GLMakie.Screen, framerate::Float64)
    @ GLMakie ~\.julia\packages\GLMakie\WcG7U\src\rendering.jl:22
 [18] renderloop(screen::GLMakie.Screen; framerate::Float64)
    @ GLMakie ~\.julia\packages\GLMakie\WcG7U\src\rendering.jl:48
 [19] renderloop(screen::GLMakie.Screen)
    @ GLMakie ~\.julia\packages\GLMakie\WcG7U\src\rendering.jl:41
 [20] (::GLMakie.var"#50#52"{GLMakie.Screen})()
    @ GLMakie .\task.jl:406
niclasmattsson commented 3 years ago

Thanks for releasing version 0.1.16! The first README example is still broken, but the same demo using the formulation in tests/runtests.jl works perfectly. As soon as you update the README you can close this issue as fixed.

Hovering over the resulting figure produces a bunch of callback errors due to the lack of an inverse_transform method, but I'll open a separate issue for that.

visr commented 3 years ago

The readme example was updated in #79, so I believe this can be closed now.