search

MakieOrg / GraphMakie.jl

Plotting graphs with Makie
https://graph.makie.org
MIT License
136 stars 23 forks source link

test on lts and pre #190

Closed hexaeder closed 2 weeks ago

hexaeder commented 4 months ago

Julia 1.11 changes the random streams. Unfortunately, that means basically all ref tests broke. Not sure how to prevent this in the future without cluttering the examples with explicit stable rng code and pass it to the layout kw of every single plot command...

mtfishman commented 3 weeks ago

We're facing the same issues in our tests. Besides passing around a StableRNG the other alternative I could think of is having version-dependent reference images, i.e. store one set of images for Julia 1.10, one for Julia 1.11, etc. (I'll do that for now since the StableRNGs.jl approach requires https://github.com/JuliaGraphs/NetworkLayout.jl/pull/65 but I'm not sure how automated it will be, i.e. it will be annoying to have to generate new images for now versions so that ideally should be automated).