search

MakieOrg / Makie.jl

Interactive data visualizations and plotting in Julia
https://docs.makie.org/stable
MIT License
2.43k stars 312 forks source link

Renaming Wong color pallete #1041

Open aramirezreyes opened 3 years ago

aramirezreyes commented 3 years ago

Hi! I was doing some reading about colorblind-friendly color schemes and saw that Makie has a group called "Wong colors" https://github.com/JuliaPlots/Makie.jl/blob/ef544356409565801e8f37b7118a0146de0f7262/src/theming.jl#L35.

However in https://github.com/matplotlib/matplotlib/issues/9460#issuecomment-817207007 I've discovered that said color pallete was published in Nature by Wong without attribution to its original authors Masataka Okabe & Kei Ito. (https://jfly.uni-koeln.de/color/#assign)

It sounds like the sensible thing to do is to attribute the original authors. Would this be a welcomed suggestion?

Thanks

logankilpatrick commented 3 years ago

This sounds fair to me, the only thing that might be helpful to have would be a little context or evidence that the color palette was indeed copied by Wong (instead of just taking the word of someone on GitHub).

aramirezreyes commented 3 years ago

That is reasonable.

One way to check that is the archive.org link from 2003 ( https://web.archive.org/web/20030821055411/http://jfly.iam.u-tokyo.ac.jp/color/text.html ). Wong´s nature paper was published in 2011 ( https://www.nature.com/articles/nmeth.1618 ).

Other nature methods paper recognizes the precedence of Okabe and Ito's paper: "Wong in a subsequent article on graphics design accounting for those with color vision deficiencies suggests using, for additive color images (typically two-channel confocal images), the method proposed by Okabe and Ito (http://jfly.iam.u-tokyo.ac.jp/color/)."

As well as other sites on the topic, e.g. https://yoshke.org/blog/essays/2020/07/colorblind-friendly-diagrams/