Open ffreyer opened 2 years ago
Here are all the scores from that test run as well as results from previous runs that did not change anything visually. To summarize:
Maybe we could try cleaning up the worst offenders in WGLMakie and aim for 0.02 as a threshold? That would leave 28 cases in the list above. Mabye for those we can create some more noise in the refimages?
Need to check if this is still true
Shouldn't, because I changed to a fixed tile based comparison at some point, and in these smaller tiles the sensitivity is higher.
The threshold is still higher than it would need to be if some noise weren't introduced by movie compression, I think the movie frames have the highest diff scores.
It's much better but @ffreyer we still had a PR not fail even though the colors of a meshscatter changed in WGLMakie... So maybe could still do with some tweaking?
I noticed in #1382, specifically https://github.com/JuliaPlots/Makie.jl/runs/3884166657 that about half the refimage tests still pass when the output is just white. It would probably be good to decrease the accuracy threshold and maybe cut/rework some tests that can't reach high accuracy.
For reference, these should be all the refimage tests that passed when comparing to a blank white output in that test run: