MakieOrg / Makie.jl

Interactive data visualizations and plotting in Julia
https://docs.makie.org/stable
MIT License
2.41k stars 313 forks source link

`resize!` does not change the size of the displayed GLMakie screen #1925

Open asinghvi17 opened 2 years ago

asinghvi17 commented 2 years ago

Calling resize!(fig, ...) or resize!(sc, ...) does not lead to the display window resizing in GLMakie. I am inclined to think this is a GLMakie-based issue - perhaps we should propagate updates to scene.px_area to the GLScreen as well?

ffreyer commented 2 years ago

I think the functionality is there, but not connected. https://github.com/JuliaPlots/Makie.jl/blob/3f8780935ee4dca7a46c44426ac8157ec9e06859/GLMakie/src/screen.jl#L176-L181

perhaps we should propagate updates to scene.px_area to the GLScreen as well?

That would probably loop infinitely because window resize events update scene.px_area.

ffreyer commented 2 months ago

Related #1821