Closed my-little-repository closed 5 years ago
SimonDanisch
commented
5 years ago Seems like tags finally went through... I started tagging yesterday, but it was held up by hiccups in the registry - which is unfortunate since I need to tag the Makie packages together.
So now you're on a new version of the tests including tests for bug fixes, while not having the bug fix versions of AbstractPlotting! add GLMakie#master AbstractPlotting#master should fix this!
judober
commented
5 years ago I'm experiencing the same issue with test Makie. The suggested solution of add GLMakie#master AbstractPlotting#master shows an error due to version incompatibilities:
ERROR: Unsatisfiable requirements detected for package ImageFiltering [6a3955dd]:
ImageFiltering [6a3955dd] log:
├─possible versions are: [0.0.1-0.0.2, 0.1.0-0.1.4, 0.2.0-0.2.3, 0.3.0, 0.4.0-0.4.1, 0.5.0-0.5.4, 0.6.0-0.6.1] or uninstalled
├─restricted to versions * by GLMakie [e9467ef8], leaving only versions [0.0.1-0.0.2, 0.1.0-0.1.4, 0.2.0-0.2.3, 0.3.0, 0.4.0-0.4.1, 0.5.0-0.5.4, 0.6.0-0.6.1]
│ └─GLMakie [e9467ef8] log:
│ ├─possible versions are: 0.0.5 or uninstalled
│ └─GLMakie [e9467ef8] is fixed to version 0.0.5
├─restricted to versions 0.6.1 by an explicit requirement, leaving only versions 0.6.1
└─restricted by compatibility requirements with MakieGallery [dbd62bd0] to versions: [0.0.1-0.0.2, 0.1.0-0.1.4, 0.2.0-0.2.3, 0.3.0, 0.4.0-0.4.1, 0.5.0-0.5.4] — no versions left
└─MakieGallery [dbd62bd0] log:
├─possible versions are: 0.0.1-0.0.7 or uninstalled
└─restricted to versions 0.0.6-* by an explicit requirement, leaving only versions 0.0.6-0.0.7add ImageFiltering#master does not help. free GLMakie seems to be the solution here but it brings back the test error when running linesegments___colors.
Any suggestions how to solve this?
asinghvi17
commented
5 years ago Looks like MakieGallery's requirements might be too strict.
asinghvi17
commented
5 years ago @judober could you try adding MakieGallery#as/bump-compat? That should resolve the version incompatibility, the port from METADATA to General has been a bit of a pain in that respect.
judober
commented
5 years ago By using add GLMakie#master AbstractPlotting#master and MakieGallery#as/bump-compat, the running linesegments___colors is passed. However the running statsmakie fails:
running statsmakie
Example Analysis failed with source:
using AbstractPlotting, Makie
using StatsMakie
using DataFrames, RDatasets # for data
using StatsMakie: smooth, linear
using Distributions
mtcars = dataset("datasets", "mtcars") # load dataset of car statistics
iris = dataset("datasets", "iris")
disallowmissing!.([mtcars, iris]) # convert columns from Union{T, Missing} to T
# We can use this because the dataset has no missing values.
ERROR: LoadError: LoadError: ArgumentError: Package Distributions not found in current path:
- Run `import Pkg; Pkg.add("Distributions")` to install the Distributions package.Adding Distributions on my end doesn't help so I guess it has to be added to Makie somewhere...
asinghvi17
commented
5 years ago Looks like I need to update the MakieGallery Project.toml some more...will get back to you when I'm done with that. Would you mind posting issues as they come through? Thanks.
asinghvi17
commented
5 years ago @judober could you ]up and try again?
judober
commented
5 years ago Alright, now the dependencies for Distributions don't seem to work out:
ERROR: Unsatisfiable requirements detected for package Distributions [31c24e10]:
Distributions [31c24e10] log:
├─possible versions are: [0.1.0-0.1.4, 0.2.0-0.2.13, 0.3.0, 0.6.4-0.6.7, 0.7.0-0.7.6, 0.8.0-0.8.10, 0.9.0, 0.10.0-0.10.2, 0.11.0-0.11.1, 0.12.0-0.12.5, 0.13.0, 0.14.0-0.14.2, 0.15.0, 0.16.0-0.16.4, 0.17.0, 0.18.0, 0.19.1-0.19.2] or uninstalled
├─restricted to versions * by MakieGallery [dbd62bd0], leaving only versions [0.1.0-0.1.4, 0.2.0-0.2.13, 0.3.0, 0.6.4-0.6.7, 0.7.0-0.7.6, 0.8.0-0.8.10, 0.9.0, 0.10.0-0.10.2, 0.11.0-0.11.1, 0.12.0-0.12.5, 0.13.0, 0.14.0-0.14.2, 0.15.0, 0.16.0-0.16.4, 0.17.0, 0.18.0, 0.19.1-0.19.2]
│ └─MakieGallery [dbd62bd0] log:
│ ├─possible versions are: 0.0.7 or uninstalled
│ └─MakieGallery [dbd62bd0] is fixed to version 0.0.7+
├─restricted to versions 0.19.2 by an explicit requirement, leaving only versions 0.19.2
└─restricted by compatibility requirements with StatsMakie [65254759] to versions: [0.1.0-0.1.4, 0.2.0-0.2.13, 0.3.0, 0.6.4-0.6.7, 0.7.0-0.7.6, 0.8.0-0.8.10, 0.9.0, 0.10.0-0.10.2, 0.11.0-0.11.1, 0.12.0-0.12.5, 0.13.0, 0.14.0-0.14.2, 0.15.0, 0.16.0-0.16.4, 0.17.0, 0.18.0] — no versions left
└─StatsMakie [65254759] log:
├─possible versions are: 0.0.1-0.0.4 or uninstalled
└─restricted to versions 0.0.0-* by an explicit requirement, leaving only versions 0.0.1-0.0.4Okay, looks like it's time to file a PR on StatsMakie too...damn, this incompatibility stuff really hits hard.
asinghvi17
commented
5 years ago @judober could you try ]add StatsMakie#as/bump-compat and then do the test? Sorry I can't do this myself, but my computer can't actually run Makie at the moment :(
judober
commented
5 years ago Ok, now there is a problem with CSV.jl. I think there were some changes to this package recently...
running statsmakie
Example Analysis failed with source:
using AbstractPlotting, Makie
using StatsMakie
using DataFrames, RDatasets # for data
using StatsMakie: smooth, linear
using Distributions
mtcars = dataset("datasets", "mtcars") # load dataset of car statistics
iris = dataset("datasets", "iris")
disallowmissing!.([mtcars, iris]) # convert columns from Union{T, Missing} to T
# We can use this because the dataset has no missing values.
ERROR: LoadError: LoadError: MethodError: no method matching CSV.File(::Base.GenericIOBuffer{Array{UInt8,1}}; delim=',', quotechar='"', missingstring="NA", rows_for_type_detect=200)Looks like a problem with RDatasets; unfortunately, I don't even think we can do anything there until they resolve their package with the changes in CSV.jl. I can (temporarily) put a cap on CSV that should solve that, if you'd like, while RDatasets gets up to speed.
judober
commented
5 years ago Well I don't know how long it takes them to solve this, but the old CSV should be allright for now.
asinghvi17
commented
5 years ago @judober I've made the changes
judober
commented
5 years ago Ok, I'll try...
judober
commented
5 years ago The result is the same as before
asinghvi17
commented
5 years ago Dangit...could you up and try again? If that still fails I'd honestly say wait till tomorrow, hopefully someone will be able to have a look at RDatasets.
asinghvi17
commented
5 years ago I just realized...I think it's going to fail anyway because the reference images are not up to date. However, as long as the first couple of tests run it's probably working fine.
asinghvi17
commented
5 years ago We'll probably have to wait for Simon to regenerate reference images on his end.
judober
commented
5 years ago Alright, then I will leave it be. Thank you anyway.
asinghvi17
commented
5 years ago Yeah, sorry about that. I'll ping you when it's done.
I am using julia 1.1.0 and I just downloaded Makie.
Running the tests gives the following error.