Open Moelf opened 3 months ago
used_attributes is for passing arguments to convert_arguments, which is where clamp_bincounts should be implemented, since you can't add custom attributes to an existing recipe.
as you may recall, that tutorial specifically deal with situation where it can't be implemented as convert_arguments
-- in this case, I already have histograms made, I can't convert them back to inputs to Makie.hist()
, it's conceptually impossible.
Shouldn't it be used_attributes(::Type{::MyHist}, ::InputType) = ...
?
The problem is that used_attributes consumes those kwargs, I think...
Building on top of the examples: https://docs.makie.org/dev/tutorials/wrap-existing-recipe
The tutorial has this snippet:
Now, let's say user wants to also customize
Makie.hist(myhist; clamp_bincounts = ...)
, they can't get this to work.In particular, it is not enough to register these:
because by the time we're inside our own
function Makie.plot!(plot::Hist{<:Tuple{<:MyHist}})
method, the attributes no longer contain the keyword argument we need.@asinghvi17