Closed asinghvi17 closed 4 days ago
Is that to-do list accurate/up-to-date? I'm not too familiar with Makie/Julia, which is why I'm in a good first issue, but I could only find 2 untracked instances of those functions: https://github.com/MakieOrg/Makie.jl/blob/86177428baa835d88ee733d4be57b5340de70053/src/basic_recipes/hvspan.jl#L49 and https://github.com/MakieOrg/Makie.jl/blob/86177428baa835d88ee733d4be57b5340de70053/src/basic_recipes/timeseries.jl#L43
The rest seem already updated, for example with commit dafd4d3fa5da8f1bf354571fec52ccbd7bea078b in https://github.com/MakieOrg/Makie.jl/pull/2731.
Welcome to the community!
Thanks for catching that - it looks like contourf and tricontourf are both OK, I probably included them mistakenly. Series also looks fine.
You mentioned hvspan and timeseries already, but there are a few more:
Volumeslices
https://github.com/MakieOrg/Makie.jl/blob/86177428baa835d88ee733d4be57b5340de70053/src/basic_recipes/volumeslices.jl#L27
(this is a bit tricky, it looks like a regular map
but x, y, z are observables. Feel free to change the function invocation to lift
for clarity)
Scatterlines has quite a few, the below statement and friends
I'd be interested in helping out as someone with little experience in Makie's internals.
I recall looking at the sankey recipe a few weeks ago and seeing the lift
function in there, too. I know that this recipe is not integrated with Makie yet and might be of low priority, but I have to plot sankeys too often and like Makie's layouting too much to not have a try.
Would it be correct to pass lift(plot, x, y, z)
there, too?
A while ago we introduced a mechanism to track Observable pipelines (created by
lift
,map
,on
, andonany
) and associate them with a plot so that they get garbage collected along with that plot. This is done by providing the plot as the second argument to the function, for examplelift(f, plot::Plot, args...)
.Most Makie recipes have already transitioned, however some still have to add this tracking. It's as simple as adding the
plot
(or whatever name theplot!
function has it under) as the second argument to the lift or similar functions withinplot!
.Specifically,
or
I made a PR to do this for
contour
in #4303, which could be a nice reference.All the recipes can be found in https://github.com/MakieOrg/Makie.jl/tree/master/src/basic_recipes
Inspired by #4302