search

MakieOrg / MakieThemes.jl

Themes for Makie
Other
26 stars 6 forks source link

Perceptually uniform `ggplot` colormaps #19

Open asinghvi17 opened 1 year ago

asinghvi17 commented 1 year ago

Would be nice to maybe depend on PerceptualColourMaps.jl for this. The current colormaps are just formed by two colors, which I would like to move past in the long term.

mkborregaard commented 1 year ago

No reason to depend on that package. Every plot package should depend on Colorschemes (and Makie already does this), which also includs all the PerceptualColorMaps under the name "colorcet".

asinghvi17 commented 1 year ago

Right, but unless I'm missing something, the colormaps here are not included in colorcet, so we'd have to generate them. They look fine now, this is more of a nice-to-have.

mkborregaard commented 1 year ago

Which colormaps are those? PerceptualColorMaps is a crazy heavy dependency, or at least it used to depend on the entire Images ecosystem

asinghvi17 commented 1 year ago

Ouch, yeah it depends on Images and PyPlot as well. Might be best to just generate the colors and write the array out in MakieThemes.

Basically all the colormaps of ggthemr aren't represented in ColorSchemes. Another idea is that we could PR them over there.

mkborregaard commented 1 year ago

Yes that would be my suggestion Colorschemes tries to be the hub of all things color