search

Makin-Things / bom-radar-card

A rain radar card using the new tiled images from the Australian BOM
https://github.com/makin-things/bom-radar-card
MIT License
98 stars 9 forks source link

No releases have compiled bom-radar-card.js asset #5

Closed huonw closed 3 years ago

huonw commented 3 years ago

Checklist:

N/A

Release with the issue: every release (including V1.2.14)

Last working release (if known): none

Browser and Operating System: N/A

Description of problem:

The readme describes a manual installation process:

If you don't use HACS, you can download js file from latest releases. ...

Unfortunately, it looks like the release CI is consistently failing (e.g. https://github.com/theOzzieRat/bom-radar-card/runs/1490808664?check_suite_focus=true ) and so the compiled asset isn't being attached.

I'm not an expert in the npm tooling, but one potential fix might be to use npm ci rather than npm install.

(Thanks for making and publishing this card!)

Javascript errors shown in the web inspector (if applicable):

N/A

Additional information:

theOzzieRat commented 3 years ago

The source code assets had all the needed files in the dist folder, but I have now fixed the pipelines. You need all of the assets not just bom-radar-card.js. It has only been released as a pre-release (V1.2.15) to avoid the majority of people that use HACS getting a meaningless update.

huonw commented 3 years ago

Great, thanks! 🎉

Minor detail, but the README says "download js file", and so it sounds like it could be adjusted to specify downloading a whole set of files? (Another option might be to zip up the dist folder so that there's just one release asset to download 🤷 )

theOzzieRat commented 3 years ago

I have updated the README to change it to be all files. I tried doing it as a zip, but that seems to break using HACS and I am not willing to do that. The doco update will just slip in with the next release whenever that is.